commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Schaible <Joerg.Schai...@scalaris.com>
Subject Re: [logging] preparing for a 1.1.2 release
Date Fri, 22 Feb 2013 07:15:28 GMT
Hi Thomas,

Thomas Neidhart wrote:

> Hi all,
> 
> I think the logging component is almost ready for a (long awaited) 1.1.2
> release. It fixes several bugs, especially a nasty deadlock in
> WeakHashtable, which was requested by several people already.
> 
> There are two issues for which I would like to get more feedback before
> starting a RC:
> 
>  * LOGGING-135: Thread-safety improvements
>    For the Log4JLogger and the LogKitLogger, I did implement the double
>    checked locking idiom from Josh Bloch for the getLogger() method.
>    Now this only works safely for Java 5+, but I was hesitating to make
>    these methods synchronized as they are used everywhere in the
>    adapter.
> 
>  * LOGGING-144: LogFactory ignores Throwable
>    There are several throw/catch(Throwable) in the code, where certain
>    exceptions like ThreadDeath are silently ignored. I provided a
>    patch, but would like some people to review it before applying it.
>    There are no reports about problems in the wild, so we could also
>    postpone this fix.

No, we should not again release something, that swallows stuff like 
ThreadDeath. Sebb is definitely right here.

Cheers,
Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message