commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1445397 - in /commons/proper/functor/trunk: build-tools/pom.xml pom.xml
Date Tue, 12 Feb 2013 22:09:13 GMT
On 12 February 2013 21:34,  <kinow@apache.org> wrote:
> Author: kinow
> Date: Tue Feb 12 21:34:47 2013
> New Revision: 1445397
>
> URL: http://svn.apache.org/r1445397
> Log:
> Setting groupId org.apache.commons in parent POM, and removing it from modules
>
> Modified:
>     commons/proper/functor/trunk/build-tools/pom.xml
>     commons/proper/functor/trunk/pom.xml
>
> Modified: commons/proper/functor/trunk/build-tools/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/build-tools/pom.xml?rev=1445397&r1=1445396&r2=1445397&view=diff
> ==============================================================================
> --- commons/proper/functor/trunk/build-tools/pom.xml (original)
> +++ commons/proper/functor/trunk/build-tools/pom.xml Tue Feb 12 21:34:47 2013
> @@ -21,9 +21,7 @@
>      <version>9</version>
>    </parent>

The parent is using groupId org.apache, because it is NOT the functor
top-level pom.

So it is not possible to default to it.

>    <modelVersion>4.0.0</modelVersion>
> -  <groupId>org.apache.commons</groupId>
>    <artifactId>commons-functor-build-tools</artifactId>
> -  <version>1.0-SNAPSHOT</version>

Why did you remove the version?
That was not discussed.

>    <name>Commons Functor Build Tools</name>
>    <description>Provide common setup, from http://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html</description>
>  </project>

-1, the build-tools module changes are wrong.

> Modified: commons/proper/functor/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/pom.xml?rev=1445397&r1=1445396&r2=1445397&view=diff
> ==============================================================================
> --- commons/proper/functor/trunk/pom.xml (original)
> +++ commons/proper/functor/trunk/pom.xml Tue Feb 12 21:34:47 2013
> @@ -23,6 +23,7 @@
>      <artifactId>commons-parent</artifactId>
>      <version>28</version>
>    </parent>
> +  <groupId>org.apache.commons</groupId>

That's OK.

>    <artifactId>commons-functor-parent</artifactId>
>    <version>1.0-SNAPSHOT</version>
>    <packaging>pom</packaging>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message