commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Date Tue, 12 Feb 2013 20:58:31 GMT
On 12 February 2013 20:42, Matt Benson <gudnabrsam@gmail.com> wrote:
> Wait, now I think we're all getting out of sync with one another.  :)  I
> can respect Sebastian's point that a Commons component's "top" pom
> explicitly declare the groupId, particularly in light of his willingness to
> omit it from any subordinate modules, so actually the change that
> precipitated this whole discussion should stand.  The groupId should then
> be explicitly added to commons-functor-parent, and can be removed from any
> child modules including build-tools.

I had not noticed that the pom in question was a module pom.

I agree that only the top-level component pom needs the groupId.
And it's then safer if the modules don't (re)define the groupId
(provided that they chain back to the top-level pom of course).

> Matt
>
>
> On Mon, Feb 11, 2013 at 6:47 PM, <kinow@apache.org> wrote:
>
>> Author: kinow
>> Date: Tue Feb 12 00:47:23 2013
>> New Revision: 1445005
>>
>> URL: http://svn.apache.org/r1445005
>> Log:
>> Remove duplicated groupId
>>
>> Modified:
>>     commons/proper/functor/trunk/api/pom.xml
>>
>> Modified: commons/proper/functor/trunk/api/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>>
>> ==============================================================================
>> --- commons/proper/functor/trunk/api/pom.xml (original)
>> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
>> @@ -22,7 +22,6 @@
>>      <artifactId>commons-functor-parent</artifactId>
>>      <version>1.0-SNAPSHOT</version>
>>    </parent>
>> -  <groupId>org.apache.commons</groupId>
>>    <artifactId>commons-functor-api</artifactId>
>>    <name>Commons Functor API</name>
>>    <description>Provide the basic APIs</description>
>>
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message