commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: svn commit: r1443696 - /commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/Argument.java
Date Sat, 09 Feb 2013 18:04:44 GMT
I have created SANDBOX-440 [1] for this.

Regards,
Benedikt

[1] https://issues.apache.org/jira/browse/SANDBOX-440


2013/2/8 Benedikt Ritter <britter@apache.org>

> Hi,
>
>
> 2013/2/8 Duncan Jones <duncan@wortharead.com>
>
>> In this specific case, I think a "..., not null" caveat is sufficient.
>> But in the general case, I think documenting interesting runtime
>> exceptions in the javadoc is good practice.
>
> Okay, I guess that's what we will do with the BeanReflectionException base
> class.
>
>
>> Does the CheckStyle config
>> need tweaking?
>>
> I think so. I'll try to have a look ASAP.
>
> thanks!
> Benedikt
>
>
>>
>> On 8 February 2013 08:26, Benedikt Ritter <britter@apache.org> wrote:
>> > Hi Simo,
>> >
>> >
>> > 2013/2/8 Simone Tripodi <simonetripodi@apache.org>
>> >
>> >> > How do you feel about this? Checkstyle complains about this, and I
>> think
>> >> it
>> >> > is sufficient to tell users that an argument must not be null.
>> >>
>> >> sorry, which one?
>> >>
>> >
>> > should have made that clearer :)
>> > I removed the @throws NullpointerException from the JavaDoc because
>> check
>> > style complains about this (NPE is not declared in the method's
>> signature).
>> > I think it is enough to tell users that an argument must not be null.
>> WDYT?
>> >
>> > Benedikt
>> >
>> >
>> >>
>> >> http://people.apache.org/~simonetripodi/
>> >> http://simonetripodi.livejournal.com/
>> >> http://twitter.com/simonetripodi
>> >> http://www.99soft.org/
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message