commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno P. Kinoshita" <ki...@apache.org>
Subject Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Date Tue, 12 Feb 2013 04:26:49 GMT
>Although strictly speaking the groupId is not required as it is
>inherited from the parent groupId, I think it's best to be explicit.

I'm fine with or without the groupId in the child project. I think it's useful to avoid misspellings
and removed because of an Eclipse warning. But if by being explicit we will help users/developers,
then I'm +1 for repeating the groupId :-) Should I revert this change then? (and perhaps
this could be a good practice for multi-module commons components too?).

Thanks

[1] https://git-wip-us.apache.org/repos/asf/maven.git

Bruno P. Kinoshita
http://kinoshita.eti.br
http://tupilabs.com


>________________________________
> From: sebb <sebbaz@gmail.com>
>To: dev@commons.apache.org 
>Sent: Tuesday, February 12, 2013 12:39 AM
>Subject: Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
> 
>On 12 February 2013 00:47,  <kinow@apache.org> wrote:
>> Author: kinow
>> Date: Tue Feb 12 00:47:23 2013
>> New Revision: 1445005
>>
>> URL: http://svn.apache.org/r1445005
>> Log:
>> Remove duplicated groupId
>>
>> Modified:
>>     commons/proper/functor/trunk/api/pom.xml
>>
>> Modified: commons/proper/functor/trunk/api/pom.xml
>> URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>> ==============================================================================
>> --- commons/proper/functor/trunk/api/pom.xml (original)
>> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
>> @@ -22,7 +22,6 @@
>>      <artifactId>commons-functor-parent</artifactId>
>>      <version>1.0-SNAPSHOT</version>
>>    </parent>
>> -  <groupId>org.apache.commons</groupId>
>
>Although strictly speaking the groupId is not required as it is
>inherited from the parent groupId, I think it's best to be explicit.
>
>>    <artifactId>commons-functor-api</artifactId>
>>    <name>Commons Functor API</name>
>>    <description>Provide the basic APIs</description>
>>
>>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message