Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3B159E41A for ; Sat, 19 Jan 2013 15:16:52 +0000 (UTC) Received: (qmail 72271 invoked by uid 500); 19 Jan 2013 15:16:51 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 71985 invoked by uid 500); 19 Jan 2013 15:16:51 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 71957 invoked by uid 99); 19 Jan 2013 15:16:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Jan 2013 15:16:50 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates 74.125.82.50 as permitted sender) Received: from [74.125.82.50] (HELO mail-wg0-f50.google.com) (74.125.82.50) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Jan 2013 15:16:42 +0000 Received: by mail-wg0-f50.google.com with SMTP id es5so2742052wgb.17 for ; Sat, 19 Jan 2013 07:16:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=z7+w3MRqOFlSWuSHPWQDbgC9WSGE69O89nVL20DH9LA=; b=xXJDHIrZHSbvjFy3ZCZ+rHZXyakhOv5RFjO1Qjky781uu/C48/KjmWTnarWxEdDOEE kLdbnmP9froTDixAr5P0YjoXrcDGryp7++DB7WHVYOW6kamkxrqFMETRhxXmcX7zSXjI +OXLV2lKsNVCeZeBNh07A3o8yrB/J8ZtmKhkFqrZvnyO79TmPSHLY3k4ZorwEWbOyrx9 MGHYMpYbBbysqhDgKZ7hBoUzFxbn3IP5gF/w6F10nsjYVEhUbEvsYEAriOAT0NtofYUn VrpuJAB1o6Vh2nsoTAYfkvzyk57SAddBWYnBFRzD/AxPncXNs7pZJbwZgIuRqmisF5Ig NsLg== MIME-Version: 1.0 X-Received: by 10.194.21.70 with SMTP id t6mr19064104wje.42.1358608582176; Sat, 19 Jan 2013 07:16:22 -0800 (PST) Received: by 10.194.234.164 with HTTP; Sat, 19 Jan 2013 07:16:22 -0800 (PST) In-Reply-To: <20130119140953.4657D23888D2@eris.apache.org> References: <20130119140953.4657D23888D2@eris.apache.org> Date: Sat, 19 Jan 2013 15:16:22 +0000 Message-ID: Subject: Re: svn commit: r1435550 - in /commons/proper/codec/trunk/src/main/java/org/apache/commons/codec: ./ binary/ digest/ language/ language/bm/ From: sebb To: dev@commons.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org On 19 January 2013 14:09, wrote: > Author: tn > Date: Sat Jan 19 14:09:52 2013 > New Revision: 1435550 > > URL: http://svn.apache.org/viewvc?rev=1435550&view=rev > Log: > Fix checkstyle warnings. > > Modified: > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/StringEncoderComparator.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base32.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base32InputStream.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base32OutputStream.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base64.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base64InputStream.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base64OutputStream.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/StringUtils.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/B64.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/Sha2Crypt.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java > commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Rule.java > > Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/StringEncoderComparator.java > URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/StringEncoderComparator.java?rev=1435550&r1=1435549&r2=1435550&view=diff > ============================================================================== > --- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/StringEncoderComparator.java (original) > +++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/StringEncoderComparator.java Sat Jan 19 14:09:52 2013 > @@ -28,6 +28,7 @@ import java.util.Comparator; > * > * @version $Id$ > */ > +@SuppressWarnings("rawtypes") -1 That is not a checkstyle warning. Suppression of generics warnings should only be done if it is not possible to fix the warning AND the warning is a false positive. If so, then a // comment should be added to the line saying why it is safe to suppress the warning. > public class StringEncoderComparator implements Comparator { > > /** > @@ -69,6 +70,7 @@ public class StringEncoderComparator imp > * @return the Comparable.compareTo() return code or 0 if an encoding error was caught. > * @see Comparable > */ > + @SuppressWarnings("unchecked") -1, as above > @Override > public int compare(final Object o1, final Object o2) { > {snip] --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org