commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Neidhart <thomas.neidh...@gmail.com>
Subject Re: svn commit: r1440524 - /commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
Date Wed, 30 Jan 2013 17:12:07 GMT
On Wed, Jan 30, 2013 at 6:05 PM, <sebb@apache.org> wrote:

> Author: sebb
> Date: Wed Jan 30 17:05:51 2013
> New Revision: 1440524
>
> URL: http://svn.apache.org/viewvc?rev=1440524&view=rev
> Log:
> Document unexpected list contents
>
> Modified:
>
> commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
>
> Modified:
> commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java?rev=1440524&r1=1440523&r2=1440524&view=diff
>
> ==============================================================================
> ---
> commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
> (original)
> +++
> commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
> Wed Jan 30 17:05:51 2013
> @@ -55,6 +55,8 @@ public class Options implements Serializ
>      private Map<String, Option> longOpts = new LinkedHashMap<String,
> Option>();
>
>      /** a map of the required options */
> +    // N.B. This can contain either a String (addOption) or an
> OptionGroup (addOptionGroup)
> +    // TODO this seems wrong
>      private List<Object> requiredOpts = new ArrayList<Object>();
>

Indeed, I also spotted this and failed to resolve it, as the logic in the
parsers is somehow taken advantage of it in a way I do not yet fully
understand.

Thomas

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message