commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dennis Lundberg <denn...@apache.org>
Subject Re: [logging] Cleanup of trunk
Date Tue, 15 Jan 2013 18:29:06 GMT
On 2013-01-15 19:20, Gary Gregory wrote:
> On Tue, Jan 15, 2013 at 1:17 PM, Dennis Lundberg <dennisl@apache.org> wrote:
> 
>> On 2013-01-12 15:03, Thomas Neidhart wrote:
>>> Hi,
>>
>> Hi Thomas
>>
>> A while back I made changes to the Maven build so that it produces the
>> same output as the Ant build. The should mean that we can get rid of the
>> old Ant build if we want to.
>>
>> One thing that I'd like to do is to restructure the source code into
>> several separate Maven modules, so that there is a specific module for
>> commons-logging-api. The current setup is error prone, as it is
>> extracting certain files from certain archives and then repackaging them
>> again, with the risk of loosing meta data like MANIFEST.MF.
>>
>>> I would like to do a similar cleanup as for email also for logging and
>>> aim for a 1.2 release in the coming weeks. The things I have in mind:
>>>
>>>  * update to Java 5
>>
>> I'm -1 on this change. I don't see any reason to do it. We don't need
>> features from a more recent Java version in commons-logging. As others
>> have said: most users of commons-logging are old and older apps.
>>
>>>  * comply to default maven structure
>>
>> +1
>>
>>>  * update to Junit 4
>>
>> +1
>>
> 
> You need Java 5 to use JUnit 4 properly. @Test...

Yes, but requiring Java 5 to build is not the same thing as setting the
minimum runtime Java version to Java 5.

Using something like animal sniffer we can make sure that we don't break
the compatibility with older JDKs. However we might need to up the
target version from 1.1 to 1.2 since there are no signatures available
for Java 1.1.

http://mojo.codehaus.org/animal-sniffer-maven-plugin/

> Gary
> 
>>
>>>  * fix the open issues wrt thread safety
>>
>> Are there patches available for these issues?
>> Which issues are we talking about?
>>
>>>  * replace WeakHashtable with a WeakHashMap or a ConcurrentHashMap (see
>>>    LOGGING-119)
>>>
>>> What do you think?
>>>
>>> Thomas
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>>
>> --
>> Dennis Lundberg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> 
> 


-- 
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message