commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: svn commit: r1416248 - in /commons/proper/email/trunk/src: changes/changes.xml java/org/apache/commons/mail/Email.java test/org/apache/commons/mail/EmailTest.java
Date Mon, 03 Dec 2012 19:16:27 GMT
On Mon, Dec 3, 2012 at 2:06 PM, Thomas Neidhart
<thomas.neidhart@gmail.com>wrote:

> On 12/03/2012 01:01 PM, sebb wrote:
> > On 3 December 2012 11:39, Gary Gregory <garydgregory@gmail.com> wrote:
> >> I think it's time to update to Java 5... it is almost 2013!
> >
> > Agreed - unless there is a particular reason why it should remain at
> Java 1.4?
>
> fine for me too. Shall we make this visible via an issue, or is it
> sufficient to mention it in the release notes?
>

Both. Use a JIRA so you can have a EMAIL-nnn tag in the commits for clean
ups like generics, varargs, for each loops, and so on.


>
> Do you also agree to move to a more maven compliant directory structure:
>
>  * src/java -> src/main/java
>  * src/resource -> src/main/resources
>  * src/test -> src/test/java + src/test/resources
>

+1

Gary


>
> Thomas
>
> >
> >> Gary
> >>
> >> On Dec 3, 2012, at 2:37, Thomas Neidhart <thomas.neidhart@gmail.com>
> wrote:
> >>
> >>> On 12/02/2012 11:07 PM, Gary Gregory wrote:
> >>>> This should be a place to use var args...
> >>>
> >>> Thanks for the hint, in this case I could not use it as email still has
> >>> to be (source) compatible with jdk 1.4.
> >>>
> >>> Thomas
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message