commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] Release of commons-email-1.3 based on RC4
Date Tue, 11 Dec 2012 02:48:59 GMT
On Mon, Dec 10, 2012 at 9:10 PM, sebb <sebbaz@gmail.com> wrote:

> On 11 December 2012 01:07, Gary Gregory <garydgregory@gmail.com> wrote:
> > On Mon, Dec 10, 2012 at 5:28 PM, Thomas Neidhart
> > <thomas.neidhart@gmail.com>wrote:
> >
> >> Hi,
> >>
> >> I would like to call a vote from commons-email-1.3 based on RC4.
> >>
> >> The files:
> >>
> >> The artifacts are deployed to Nexus:
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-135/
> >>
> >> The tag:
> >> http://svn.apache.org/viewvc/commons/proper/email/tags/EMAIL_1_3_RC4/
>

This is not the tag, it's a ViewVc URL.

Gary


> >>
> >> The site:
> >> http://people.apache.org/builds/commons/email/1.3/RC4/
> >>
> >
> > This statement is misleading IMO: "The latest version v1.3, is JDK 1.5
> > compatible"
> >
> > It should be: "The latest version, 1.3, requires Java 5"
> >
> > I agree with Sebb on the other points.
> >
> > Fixing the PMD issues seems easy while you are in there. The "Avoid empty
> > catch blocks" are clearly false positives.
> >
> > Any reason why javax.mail/mail 1.4.4 is used instead of 1.4.5?
> >
> > WRT FindBugs, this one looks like it needs fixing or documenting:
> >
> https://people.apache.org/builds/commons/email/1.3/RC4/xref/org/apache/commons/mail/util/MimeMessageUtils.html#130
>
> The Javadoc already says it uses the default encoding, and there is an
> alternate method that takes an InputStream.
>
> So I think it would be sufficient to suppress the Findbugs warning.
>
> > WRT the 1st FindBugs issue
> >
> https://people.apache.org/builds/commons/email/1.3/RC4/xref/org/apache/commons/mail/EmailException.html#105I
> > do not know, it seems like that code is pretty generic. Would passing
> > in
> > a Charset or charset name be appropriate?
> >
> > +0
> >
> > Gary
> >
> > Additional Notes:
> >>
> >> o the RC is binary compatible to commons-email-1.2 whereas the
> >>   remaining Clirr warnings stem from moving constants to an interface
> >>   and have already been verified to not break BC.
> >> o source / binary compatibility has been upgraded to JDK 1.5
> >>
> >> Please take a look at the commons-email-1.3 artifacts and vote!
> >>
> >> ------------------------------------------------
> >> [ ] +1 release it
> >> [ ] +0 go ahead I don't care
> >> [ ] -1 no, do not release it because
> >> ------------------------------------------------
> >>
> >> Vote will remain open for at least 72 hours.
> >>
> >> Thanks in advance,
> >>
> >> Thomas
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message