Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BFA19DA76 for ; Mon, 26 Nov 2012 17:29:43 +0000 (UTC) Received: (qmail 57411 invoked by uid 500); 26 Nov 2012 17:29:43 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 57070 invoked by uid 500); 26 Nov 2012 17:29:43 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 57046 invoked by uid 99); 26 Nov 2012 17:29:42 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Nov 2012 17:29:42 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,URIBL_DBL_REDIR X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of garydgregory@gmail.com designates 209.85.161.171 as permitted sender) Received: from [209.85.161.171] (HELO mail-gg0-f171.google.com) (209.85.161.171) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Nov 2012 17:29:36 +0000 Received: by mail-gg0-f171.google.com with SMTP id 4so904611ggm.30 for ; Mon, 26 Nov 2012 09:29:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=jv6J/gO3KIDV84NladhdMNpjA/sCwKvpMloDdME3kw0=; b=RecUKZLLk1zncRB4CHQYJu714x0yuwPwWBrYLmGBYq9OPt4EYAyITT0MBbpsJdAy2S r09Rjq+A1NfqJpF2bn+DUr/fzL4dogE2cTpsZsnRuGjWXatDBc/cxC1V4aZgSExUJaqs VzEWtRI5xSV/CY1pbBdGjyi1Rh7PfJIt6QY7RIqDciSNT6rLt+FmeXNxsFH9RuOiJwcv ezc+SL6dvgkIxv7rZqWfEA/SHyMkSz87Tvytxt6Wv/xGuQCZdfpPbFBkzO81ds5MSsR2 CGuBVixiSdjm/y3gX3/qXvLgRyDxkDcdeN1xMevHmvZ8gkLPhwvYavwAUYBNbc45oekf kM6w== MIME-Version: 1.0 Received: by 10.236.144.165 with SMTP id n25mr12562416yhj.61.1353950955845; Mon, 26 Nov 2012 09:29:15 -0800 (PST) Received: by 10.146.59.20 with HTTP; Mon, 26 Nov 2012 09:29:15 -0800 (PST) In-Reply-To: References: <50ABFD1D.4020205@apache.org> <-4391643847510383239@unknownmsgid> Date: Mon, 26 Nov 2012 12:29:15 -0500 Message-ID: Subject: Re: [CSV] Discussion about the new CSVFormatBuilder From: Gary Gregory To: Commons Developers List Content-Type: multipart/alternative; boundary=20cf303ea440c4398f04cf69454c X-Virus-Checked: Checked by ClamAV on apache.org --20cf303ea440c4398f04cf69454c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Now what? I'd like to release a 1.0 but we need to come to some agreement on a config API... Gary On Thu, Nov 22, 2012 at 3:16 AM, Benedikt Ritter wrot= e: > Maybe we first have to decide if we want validation of CSVFormats at > construction time or not. If not, the changes of CSV-68 can be reverted. > > Benedikt > > 2012/11/21 James Carman > > > I don't really have a problem with the extra call to build() before > > you have something useful. It does give us the ability to do > > validation on the object before you build it. If we choose not to do > > the validation at this time, that's fine, but if we ever do choose to > > add that in the future, we don't have to break API backward > > compatibility to do so. > > > > On Tue, Nov 20, 2012 at 5:57 PM, Gary Gregory > > wrote: > > > Ok this is good. Let's see some healthy debating. :) > > > > > > What is the alternate API? > > > > > > To me the bother is the extra build() call, but that's the pattern. > > > > > > Could an alt API be used and co-exist? > > > > > > Is making the ctor an option? It would have to do some validation. > > > > > > Gary > > > > > > On Nov 20, 2012, at 16:59, Emmanuel Bourg wrote: > > > > > >> Le 20/11/2012 20:01, Benedikt Ritter a =C3=A9crit : > > >> > > >>> Please share your thoughts about the builder. > > >> > > >> Sorry Benedikt but I have to say I really don't like this design. I > > >> prefer a simpler API for the reasons you mentioned in the > disadvantages. > > >> The minor improvements from the developer's point of view are much > less > > >> important than the ease of use from user's point of view. > > >> > > >> Emmanuel Bourg > > >> > > >> > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > > > For additional commands, e-mail: dev-help@commons.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > > For additional commands, e-mail: dev-help@commons.apache.org > > > > > --=20 E-Mail: garydgregory@gmail.com | ggregory@apache.org JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 Spring Batch in Action: http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory --20cf303ea440c4398f04cf69454c--