Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of garydgregory@gmail.com
 designates 209.85.160.67 as permitted sender)
MIME-Version: 1.0
Date: Sun, 4 Nov 2012 09:06:37 -0500
Message-ID: 
 <CACZkXPywVHzm5cwh5+PXzMuwnYCDoay6S78u_eMXwL_fZFDF4w@mail.gmail.com>
Subject: [v2] org.apache.logging.log4j.core.Logger.log(Marker, String, Level,
 Message, Throwable)
From: Gary Gregory <garydgregory@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary=e89a8f64328e93f72f04cdabe046

--e89a8f64328e93f72f04cdabe046
Content-Type: text/plain; charset=UTF-8

I wonder if in:

org.apache.logging.log4j.core.Logger.log(Marker, String, Level, Message,
Throwable)

    @Override
    public void log(Marker marker, String fqcn, Level level, Message data,
Throwable t) {
        if (data == null) {
            data = new SimpleMessage("");
        }
        config.config.getConfigurationMonitor().checkConfiguration();
        config.loggerConfig.log(getName(), marker, fqcn, level, data, t);
    }

The null guard should be pushed all the way down to:

org.apache.logging.log4j.core.impl.Log4jLogEvent.Log4jLogEvent(String,
Marker, String, Level, Message, Throwable, Map<String, String>,
ContextStack, String, StackTraceElement, long)

Which already does some constructor checks for other args.

?

Gary
-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

--e89a8f64328e93f72f04cdabe046--