Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of Jared.Becksfort@stjude.org
 designates 192.55.208.21 as permitted sender)
Message-ID: <8172D639BA76A14AA5C9DE7E13E0CEBE4DBEC20F87@10.stjude.org>
From: "Becksfort, Jared" <Jared.Becksfort@STJUDE.ORG>
To: Commons Developers List <dev@commons.apache.org>
Date: Fri, 9 Nov 2012 10:14:47 -0600
Subject: RE: [math] Math-817 and .equals questions.    .
Thread-Topic: [math] Math-817 and .equals questions.    .
Thread-Index: Ac29QD/AR0+qiTTXQUqAMwNF5L1AhQBVPtbg
References: <8172D639BA76A14AA5C9DE7E13E0CEBE4DBEB60BAD@10.stjude.org>
In-Reply-To: <8172D639BA76A14AA5C9DE7E13E0CEBE4DBEB60BAD@10.stjude.org>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-SEF-7853D99-ADF1-478E-8894-213D316B8FFA: 1
X-V-Loop: Yes
X-Virus-Checked: Checked by ClamAV on apache.org

Any thoughts on the below email?  If not, I will submit one patch, probably=
 today or tomorrow.

-------------------------------

Hello,

I am about to submit some code for issue Math-817 involving fitting multiva=
riate normal mixture models using the EM algorithm.  In order to simplify t=
he unit test, I added overrode equals and hashCode.  This in turn required =
me to make a few changes to code in the previously resolved issues Math-815=
 and Math-816.  Am I supposed to just send one patch to 817, or am I suppos=
ed to break the patches up according to issue number?

Also, I notice the equals method in org.apache.commons.math3.linear.Abstrac=
tRealMatrix directly compares the results of getEntry(), which are often do=
ubles.  Is this OK?  I don't have a great deal of experience in overriding =
equals where doubles are involved.  I have read that it is a good idea to u=
se Double.doubleToLongBits and the use "=3D=3D" or "!=3D".

http://www.javapractices.com/topic/TopicAction.do?Id=3D17

Thanks,
Jared

Email Disclaimer:  www.stjude.org/emaildisclaimer Consultation Disclaimer: =
 www.stjude.org/consultationdisclaimer


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org