Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 57B23D75A for ; Tue, 13 Nov 2012 05:17:43 +0000 (UTC) Received: (qmail 9250 invoked by uid 500); 13 Nov 2012 05:17:42 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 9105 invoked by uid 500); 13 Nov 2012 05:17:41 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 9053 invoked by uid 99); 13 Nov 2012 05:17:38 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Nov 2012 05:17:38 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of garydgregory@gmail.com designates 209.85.210.43 as permitted sender) Received: from [209.85.210.43] (HELO mail-da0-f43.google.com) (209.85.210.43) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Nov 2012 05:17:31 +0000 Received: by mail-da0-f43.google.com with SMTP id u36so3244649dak.30 for ; Mon, 12 Nov 2012 21:17:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:from:in-reply-to:mime-version:date:message-id:subject:to :content-type; bh=alUQG4DMZEXmvz5i0nuNvOjJAgsjm4/aKD1GqhFoh3Q=; b=GQWIPmjQNolH2UVfdI0ny35izf8/IGDlbWy9xX8bEfzQT5lUS+KEMBDT0j62RFGTXS QARimOflxouizdxzI+8u3u+WopjuxtB5Ap3XPlEHAlr20jkQSI4y3IPImhxi58tGhZg3 N6awh2wtq4YXDb2Klg4gHTQQdmzZ5cbph4ZvPyMlTbVe5t9WLjhTy75MaFwZMd22qhqS xZXWE/VGAtsO6sWZD+UX8/7jNdhojdElh0PUoaYEIbfaLFNhFH1aCxckfYPM1tVD5Zg0 b4oOCNLGDoyVXwgu3JsyVynjMB9ChwvR9OFII22I1RwioeembFjTc9DEhs7gAFidkZo1 9vjw== Received: by 10.68.191.200 with SMTP id ha8mr63907063pbc.51.1352783829987; Mon, 12 Nov 2012 21:17:09 -0800 (PST) References: From: Gary Gregory In-Reply-To: Mime-Version: 1.0 (1.0) Date: Tue, 13 Nov 2012 00:17:09 -0500 Message-ID: <-2033514319880174683@unknownmsgid> Subject: Re: Code refactoring in NumberUtils To: Commons Developers List Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org Please create a Jira and attach your patch there. Thank you, Gary On Nov 12, 2012, at 23:08, Lam nguyen phuc wrote: > Hi, > > There are a few redundant pieces of code in NumberUtils which should be removed. Attached is the diff file after doing refactoring. Note that all test cases for NumberUtils still pass successfully with this change of code. > > Regards, > Harry > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org