commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Schaible <joerg.schai...@gmx.de>
Subject Re: svn commit: r1405889 - in /commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration: Configuration.java ImmutableConfiguration.java
Date Mon, 05 Nov 2012 22:04:16 GMT
Benedikt Ritter wrote:

> 2012/11/5 Benedikt Ritter <beneritter@gmail.com>
> 
>> Hi Oliver,
>>
>>
>> 2012/11/5 <oheger@apache.org>
>>
>> Author: oheger
>>> Date: Mon Nov  5 17:29:01 2012
>>> New Revision: 1405889
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1405889&view=rev
>>> Log:
>>> Initial version of an immutable configuration interface.
>>>
>>> Added:
>>>
>>> 
commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/ImmutableConfiguration.java
>>>   (with props)
>>> Modified:
>>>
>>> 
commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java
>>>
>>> Modified:
>>> 
commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java
>>> URL:
>>> 
http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java?rev=1405889&r1=1405888&r2=1405889&view=diff
>>>
>>> 
==============================================================================
>>> ---
>>> 
commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java
>>> (original)
>>> +++
>>> 
commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java
>>> Mon Nov  5 17:29:01 2012
>>> @@ -17,11 +17,6 @@
>>>
>>>  package org.apache.commons.configuration;
>>>
>>> -import java.math.BigDecimal;
>>> -import java.math.BigInteger;
>>> -import java.util.Iterator;
>>> -import java.util.List;
>>> -import java.util.Properties;
>>>
>>>  /**
>>>   * <p>The main Configuration interface.</p>
>>> @@ -54,7 +49,7 @@ import java.util.Properties;
>>>   * @author Commons Configuration team
>>>   * @version $Id$
>>>   */
>>> -public interface Configuration
>>> +public interface Configuration extends ImmutableConfiguration
>>>
>>
>> A Configuration IS_A ImmutableConfiguration sounds rather akward. The
>> JavaDoc of ImmutableConfiguration says "The main interface for accessing
>> configuration data in a read-only fashion." Maybe ImmutableConfiguration
>> should be renamed to ReadOnlyConfiguration?
>>
>> Regards,
>> Benedikt
>>
> 
> Looking at the code base, there is no class that implements
> ImmutableConfiguration directly and Configuration is the only interface
> that extends ImmutableConfiguration. So maybe the two can be merged
> together?

And why do YOU think, that an immutable and a mutable Configuration is the 
same thing? Sorry, your comments do not make any sense to me!

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message