commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1397903 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
Date Mon, 15 Oct 2012 15:10:26 GMT
On 13 October 2012 18:18,  <ggregory@apache.org> wrote:
> Author: ggregory
> Date: Sat Oct 13 17:18:56 2012
> New Revision: 1397903
>
> URL: http://svn.apache.org/viewvc?rev=1397903&view=rev
> Log:
> In-line comment.
>
> Modified:
>     commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
>
> Modified: commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
> URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java?rev=1397903&r1=1397902&r2=1397903&view=diff
> ==============================================================================
> --- commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java (original)
> +++ commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java Sat
Oct 13 17:18:56 2012
> @@ -264,6 +264,7 @@ public class CSVParser implements Iterab
>                  try {
>                      return nextRecord();
>                  } catch (final IOException e) {
> +                    // This is not great, throw an ISE instead?

Should flag such comments as // TODO ?

Otherwise, they are difficult to find.
>                      throw new RuntimeException(e);
>                  }
>              }
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message