commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maurizio Cucchiara <mcucchi...@apache.org>
Subject Re: [OGNL] A new release
Date Wed, 24 Oct 2012 07:10:09 GMT
That's really weird, last time I have seen (and also corrected) a bunch of
error like this, but they all were more than justified.

I'll try to generate the report and see what happens.

Sent from my mobile device, so please excuse typos and brevity.

Maurizio Cucchiara
Il giorno 24/ott/2012 08.19, "Lukasz Lenart" <lukaszlenart@apache.org> ha
scritto:

> 2012/3/9 Simone Tripodi <simonetripodi@apache.org>:
> > I don't think it is necessary when fixing this kind of issues, unless
> > you need to heavily change the code, but I don't suspect so ;)
> > let me know if I can be helpful in some way - more than just helping
> > on fixing issues :P
>
> I have few doubts regarding checkstyle report, there are many issues
> related to JavaDocs and some line are too long and so one - I don't
> treat them as a big problems (especially with current formatting). But
> there are some strange errors like [2] which says:
>
> Name 'INDEXED_PROPERTY_NONE' must match pattern '^[a-z][a-zA-Z0-9]*$'.
> Variable 'INDEXED_PROPERTY_NONE' must be private and have accessor methods
>
> where the INDEXED_PROPERTY_NONE is defined as a constant:
>
> public static final int INDEXED_PROPERTY_NONE = 0;
>
> It looks like the checkstyle is configured in wrong way. Is there a
> Commons official checkstyle config ? Or am I free to adjust checkstyle
> included with OGNL ?
>
> [1] http://commons.apache.org/ognl/checkstyle.html
> [2]
> http://commons.apache.org/ognl/checkstyle.html#org.apache.commons.ognl.OgnlRuntime.java
>
>
> Regards
> --
> Ɓukasz
> mobile +48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message