commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: svn commit: r1397903 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
Date Tue, 16 Oct 2012 11:51:56 GMT
On Mon, Oct 15, 2012 at 11:10 AM, sebb <sebbaz@gmail.com> wrote:

> On 13 October 2012 18:18,  <ggregory@apache.org> wrote:
> > Author: ggregory
> > Date: Sat Oct 13 17:18:56 2012
> > New Revision: 1397903
> >
> > URL: http://svn.apache.org/viewvc?rev=1397903&view=rev
> > Log:
> > In-line comment.
> >
> > Modified:
> >
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
> >
> > Modified:
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java?rev=1397903&r1=1397902&r2=1397903&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
> (original)
> > +++
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
> Sat Oct 13 17:18:56 2012
> > @@ -264,6 +264,7 @@ public class CSVParser implements Iterab
> >                  try {
> >                      return nextRecord();
> >                  } catch (final IOException e) {
> > +                    // This is not great, throw an ISE instead?
>
> Should flag such comments as // TODO ?
>

Done.

G

>
> Otherwise, they are difficult to find.
> >                      throw new RuntimeException(e);
> >                  }
> >              }
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message