commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Duncan Jones <dun...@wortharead.com>
Subject Re: [lang] Some first steps to implementing LANG-637
Date Mon, 01 Oct 2012 13:07:40 GMT
> On Sep 23, 2012, at 2:43 PM, Duncan Jones <duncan@wortharead.com> wrote:
>
>> Hi everyone,
>>
>> I've begun work on implementing a DifferenceBuilder class as requested
>> in LANG-637. I've attached some partial implementations of a builder
>> and associated interface and test to the JIRA issue
>> (https://issues.apache.org/jira/browse/LANG-637). Before I spend too
>> much time adding upteem method overrides, constructors and tests, I'd
>> really appreciate the thoughts of the community on what I've attached.
>>
>> Assuming this functionality even has a place in commons-lang, are
>> there any glaring design flaws in what I've attached that would make
>> further work on the particular implementations foolhardy?

I've now uploaded a complete solution for LANG-637 (see
commons-lang3-LANG-637-complete.patch in JIRA) and I would very much
appreciate feedback on the design and implementation. I've already
factored in comments from James C and Matt B.

I leant heavily on the existing reflection work in EqualsBuilder when
adding the same functionality to my DiffBuilder class. If any part of
my code particularly requires review, it is that area. Not just in the
implementation details, but in some of the design decisions
(particularly whether it is correct to throw a CastClassException when
the types are not suited for comparison).

Thanks,

Duncan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message