Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of garydgregory@gmail.com
 designates 209.85.210.43 as permitted sender)
References: 
 <CACZkXPwwuvthuo8jR67BQEDRQU2G_G5ksOzKYZ4DaC6ND3hZrg@mail.gmail.com>
 <CAOGo0VYRAp49s+CHQ9J1uKMz6CjsvG-KccGZZyHY8LWEk5_saQ@mail.gmail.com>
From: Gary Gregory <garydgregory@gmail.com>
In-Reply-To: 
 <CAOGo0VYRAp49s+CHQ9J1uKMz6CjsvG-KccGZZyHY8LWEk5_saQ@mail.gmail.com>
Mime-Version: 1.0 (1.0)
Date: Sun, 2 Sep 2012 16:17:55 -0400
Message-ID: <-3726659023867021395@unknownmsgid>
Subject: Re: [codec] Getting ready for an RC
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=UTF-8

On Sep 2, 2012, at 15:51, sebb <sebbaz@gmail.com> wrote:

> On 2 September 2012 19:45, Gary Gregory <garydgregory@gmail.com> wrote:
>> Hi All:
>>
>> There has been a recent mini-flury of changes in codec as a release
>> candidate is approaching.
>>
>> Thank you to all the committers and patchers for helping codec move closer
>> to another release.
>>
>> This coming week or next weekend, I'd like to roll an RC.
>>
>> Does anyone want to discuss anything or fiddle with code before I proceed?
>
> DigestUtils shaHex methods have been deprecated in favour of sha1Hex;
> as such I would expect the shaHex implementations to delegate to sha1.
> Instead they have their own implementations; it is only by comparison
> with the sha1 versions that one can see they are the same.
>

It is not clear to me that calling DigestMessage with "SHA" and
"SHA-1" does the same thing because different objects are returned,
likely because neither are cached. Because "SHA" is not an official
name I did not want to take the risk. If both names are aliases, then
we can and should redirect one to the other.

> [If this is done, could then consider dropping the shaHex test case.]
>
> Also, why is getShaDigest not deprecated in favour of getSha1Digest?

It should be. That's an omission.

Gary
>
> Still looking at the rest of the code.
>
>> Thank you,
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org