commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Schaible <joerg.schai...@gmx.de>
Subject Re: svn commit: r1391258 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/Conversion.java
Date Sat, 29 Sep 2012 11:00:20 GMT

sebb wrote:

> On 28 September 2012 18:47, Jörg Schaible <joerg.schaible@gmx.de> wrote:
>> sebb wrote:
>>

[snip]

>>> Unless there is a significant improvement across several Java
>>> versions, I'm -1 on the change as the code is now more obscure.
>>
>> Done.
> 
> Thanks!
> 
>> Any comment on replacing the standard hex representation (i.e. lower case
>> letters like JDK does)?
> 
> 50/50

I tend to follow the JDK here.

> But it needs to be documented better; e.g. intToHexDigitM0 does not
> say whether output is upper or lower case.
> 
> It's good that the code accepts either case on input.
> 
> ==
> 
> I find the naming convention rather difficult to follow.
> 
> For example, the letter 's' sometimes means 'array' and sometimes means
> 'string' Also M0 is not obvious as an abbreviation, nor is BeM0

I am all open for better names, all *I* want to have is the functionality.

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message