commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1380305 - in /commons/proper/codec/trunk/src/main/java/org/apache/commons/codec: Charsets.java binary/Hex.java net/BCodec.java net/QCodec.java net/QuotedPrintableCodec.java
Date Mon, 03 Sep 2012 19:10:22 GMT
On 3 September 2012 19:55, Thomas Neidhart <thomas.neidhart@gmail.com> wrote:
> On 09/03/2012 08:48 PM, sebb wrote:
>> On 3 September 2012 19:37,  <tn@apache.org> wrote:
>>> Author: tn
>>> Date: Mon Sep  3 18:37:21 2012
>>> New Revision: 1380305
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1380305&view=rev
>>> Log:
>>> Fixed findbugs warning wrt unused imports resulting from javadoc types.
>>
>> Another way to fix this would be to add the exceptions to the throws
>> clause; then the import would not be redundant (and the Javadoc would
>> be a bit shorter).
>>
>> But not necessary to change this here; perhaps consider for other cases?
>
> yes good idea, we do this effort now in commons-math, so I guess we
> could extend it to other components as well.

Yes, worth working towards as time permits.

I find it a bit odd to see a different list of entries in throws and @throws.
I expect to see @throws tags used to document the condition under
which each throws entry can occur.

> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message