commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@gmail.com>
Subject Re: [lang] Etiquette regarding updating test classes to use JUnit 4 annotations
Date Mon, 17 Sep 2012 18:03:29 GMT
Hello,
  We'd love to have our whole testsuite updated to JUnit 4, IMO.  The
only thing is that as a rule we'd rather that changeset be separate
from another, so I'd recommend providing multiple patches, possibly
submitted in separate JIRA issues.

Matt

On Mon, Sep 17, 2012 at 12:59 PM, Duncan Jones <duncan@wortharead.com> wrote:
> Hi,
>
> While working on a patch for LANG-799, I ran into a problem where I
> couldn't use JUnit4 Assume.* methods because the DateUtilsTest.java
> extends TestCase (forcing JUnit3 behaviour), rather than using JUnit4
> annotations.
>
> Is it rude to adjust this class to use JUnit4 annotations? There seem
> to be other classes that avoid extending TestCase, including
> CompareToBuilderTest.java (whose SVN history shows a previous port to
> using JUnit4 lingo).
>
> I don't want to muddy my patch with a major test code refactory, so
> for now I will work around the missing Assume.* functionality. But I'd
> like to know the approach to take in the future - should I raise a bug
> against a particular test file with a patch to port it? Should there
> be a bug that requests the port of all test files to JUnit4?
>
> Kind regards,
>
> Duncan Jones
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message