commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [lang] Etiquette regarding updating test classes to use JUnit 4 annotations
Date Mon, 17 Sep 2012 18:39:19 GMT
On Mon, Sep 17, 2012 at 2:27 PM, Matt Benson <gudnabrsam@gmail.com> wrote:

> On Mon, Sep 17, 2012 at 1:19 PM, Duncan Jones <duncan@wortharead.com>
> wrote:
> > On 17 September 2012 19:13, Duncan Jones <duncan@wortharead.com> wrote:
> >> On 17 September 2012 19:07, Gary Gregory <garydgregory@gmail.com>
> wrote:
> >>> On Mon, Sep 17, 2012 at 2:03 PM, Matt Benson <gudnabrsam@gmail.com>
> wrote:
> >>>
> >>>> Hello,
> >>>>   We'd love to have our whole testsuite updated to JUnit 4, IMO.  The
> >>>> only thing is that as a rule we'd rather that changeset be separate
> >>>> from another, so I'd recommend providing multiple patches, possibly
> >>>> submitted in separate JIRA issues.
> >>>>
> >>>
> >>> +1!
> >>>
> >>> Patch 1: Update to JUnit 4
> >>> Patch 2: the patch
> >>
> >> No problem, I like that approach.
> >
> > On second thought, how would I best accomplish this? If I create a
> > patch after converting the test case, then create another patch after
> > fixing the issue, the latter patch will contain the changes from the
> > first patch. Is this ok with everyone? Or is there some patch
> > difference tool I should know about?
> >
>

Git can help I suppose... But, I'd rather deal with these patches in two
themes in this case, JUnit 4 and then whatever comes next. If we are going
to spend time on JUnit 4, let's get in that mode, get it done and then move
on to other kinds of patches.

I do not plan on spending time teasing out a git patch on top of another
that clashes with something in SVN trunk.

Gary

>
> Good point.  I haven't played with it yet, but our github clone might
> provide some traction here.
>
> Matt
>
> > Duncan
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message