commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject [all] FindBugs' Switch statement found in class.method where default case is missing
Date Tue, 04 Sep 2012 12:27:19 GMT
Hi All:

FindBugs can give warnings like:

Switch statement found in
org.apache.commons.codec.binary.Base32.decode(byte[], int, int,
BaseNCodec$Context) where default case is missing

In this case for [codec], it looks like the code was carefully constructed
and that no default clause is needed.

In these cases for any component, this FindBugs issue feels like a style
issue, is it worth changing the code to add a default clause like:

   default:
      // ok to fall through for other values.
      break;

Or does this feel like noise to you all?

Gary

-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message