commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [codec] Resolving no default in switch FindBugs issues
Date Sun, 09 Sep 2012 19:00:09 GMT
On Sun, Sep 9, 2012 at 9:43 AM, sebb <sebbaz@gmail.com> wrote:

> On 9 September 2012 01:56, Gary Gregory <garydgregory@gmail.com> wrote:
> > Hi All:
> >
> > @Sebb: Didn't you do the re-write of the BaseN code? If so, can you
> address
> > the couple of missing default clause issues reported by FindBugs?
>
> Yes, I did do some refactoring, but I don't think that involved the
> switch statements directly.
>
> However, I've added what appears to be necessary extra cases and defaults.
> There is one case which is not exercised by tests, so I added a TODO.
>
> We need more tests...
>

My plan is to roll a 1.7 RC, probably tomorrow. More test coverage is
always good, but I'm not sure how easy it is to hit that the few case
statements that remain... It looks like we've covered all the examples from
the RFCs for B32 and B64.

Any and all help is appreciated!

Gary


>
> > Unless someone else kicks in the effort that is :)
> >
> > We [all] discussed this recently and the consensus seems to be to add
> > default clauses with documentation or a throws statement.
> >
> > I took a peek and there is some subtle behavior going on there especially
> > regarding the modulus field. I'd rather have the original author provide
> > this change.
> >
> > Thank you,
> > Gary
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message