commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: svn commit: r1383747 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/exception/util/ main/resources/assets/org/apache/commons/math3/exception/util/ test/java/org/apache/commons/math3/exception/util/
Date Wed, 12 Sep 2012 10:28:47 GMT
Hi S├ębastien.

> Author: celestin
> Date: Wed Sep 12 03:46:31 2012
> New Revision: 1383747
> 
> URL: http://svn.apache.org/viewvc?rev=1383747&view=rev
> Log:
> Added new localized error message "entry {0}" to signal null entries in FieldVectors.
> 
> Modified:
>     commons/proper/math/trunk/src/main/java/org/apache/commons/math3/exception/util/LocalizedFormats.java
>     commons/proper/math/trunk/src/main/resources/assets/org/apache/commons/math3/exception/util/LocalizedFormats_fr.properties
>     commons/proper/math/trunk/src/test/java/org/apache/commons/math3/exception/util/LocalizedFormatsTest.java
> 
> Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/exception/util/LocalizedFormats.java
> URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/exception/util/LocalizedFormats.java?rev=1383747&r1=1383746&r2=1383747&view=diff
> ==============================================================================
> --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/exception/util/LocalizedFormats.java
(original)
> +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/exception/util/LocalizedFormats.java
Wed Sep 12 03:46:31 2012
> @@ -97,6 +97,7 @@ public enum LocalizedFormats implements 
>      EMPTY_SELECTED_ROW_INDEX_ARRAY("empty selected row index array"),
>      EMPTY_STRING_FOR_IMAGINARY_CHARACTER("empty string for imaginary character"),
>      ENDPOINTS_NOT_AN_INTERVAL("endpoints do not specify an interval: [{0}, {1}]"),
> +    ENTRY("entry {0}"),
>      EQUAL_VERTICES_IN_SIMPLEX("equal vertices {0} and {1} in simplex configuration"),
>      EULER_ANGLES_SINGULARITY("Euler angles singularity"),
>      EVALUATION("evaluation"), /* keep */

Sorry, this is again a discussion that started before your arrival as CM
contributor. There are far too many of these enum instances (another of
what I call "little defects").
In particular, many convey similar meanings. Duplicates should be removed,
and especially none should be added. :-}

There is an INDEX instance, so that an ENTRY instance is not necessary in my
opinion.  [The word "index" represents precisely what's in the "{0}"
placeholder.]

Is there a reason to prefer ENTRY over INDEX?

Best,
Gilles

P.S. It is possible to "stack" messages (and thus instances of the enum) so
     as to add more information into the exception's detailed message.

> 
> Modified: commons/proper/math/trunk/src/main/resources/assets/org/apache/commons/math3/exception/util/LocalizedFormats_fr.properties
> URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/resources/assets/org/apache/commons/math3/exception/util/LocalizedFormats_fr.properties?rev=1383747&r1=1383746&r2=1383747&view=diff
> ==============================================================================
> --- commons/proper/math/trunk/src/main/resources/assets/org/apache/commons/math3/exception/util/LocalizedFormats_fr.properties
(original)
> +++ commons/proper/math/trunk/src/main/resources/assets/org/apache/commons/math3/exception/util/LocalizedFormats_fr.properties
Wed Sep 12 03:46:31 2012
> @@ -69,6 +69,7 @@ EMPTY_SELECTED_COLUMN_INDEX_ARRAY = tabl
>  EMPTY_SELECTED_ROW_INDEX_ARRAY = tableau des indices de lignes s\u00e9lectionn\u00e9es
vide
>  EMPTY_STRING_FOR_IMAGINARY_CHARACTER = cha\u00eene vide pour le caract\u00e8 imaginaire
>  ENDPOINTS_NOT_AN_INTERVAL = les bornes ne d\u00e9finissent pas un intervalle : [{0},
{1}]
> +ENTRY = \u00e9l\u00e9ment {0}
>  EQUAL_VERTICES_IN_SIMPLEX = sommets {0} et {1} \u00e9gaux dans la configuration du simplex
>  EULER_ANGLES_SINGULARITY = singularit\u00e9 d''angles d''Euler
>  EVALUATION = \u00e9valuation
> 
> Modified: commons/proper/math/trunk/src/test/java/org/apache/commons/math3/exception/util/LocalizedFormatsTest.java
> URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math3/exception/util/LocalizedFormatsTest.java?rev=1383747&r1=1383746&r2=1383747&view=diff
> ==============================================================================
> --- commons/proper/math/trunk/src/test/java/org/apache/commons/math3/exception/util/LocalizedFormatsTest.java
(original)
> +++ commons/proper/math/trunk/src/test/java/org/apache/commons/math3/exception/util/LocalizedFormatsTest.java
Wed Sep 12 03:46:31 2012
> @@ -36,7 +36,7 @@ public class LocalizedFormatsTest {
>  
>      @Test
>      public void testMessageNumber() {
> -        Assert.assertEquals(310, LocalizedFormats.values().length);
> +        Assert.assertEquals(311, LocalizedFormats.values().length);
>      }
>  
>      @Test
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message