commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: [Math] About "NullArgumentException"
Date Mon, 10 Sep 2012 22:46:47 GMT
On Mon, Sep 10, 2012 at 08:47:35PM +0200, S├ębastien Brisard wrote:
> Hi
> What should I do there?

If we adopt the "flexible" policy (cf. other post), then you can do what you
want. ;-)

> I'm trying to work on MATH-854. It turns out that FieldElement<T>.add
> throws a NAE. Should I catch it below, and rethrow it with a more
> detailed message (including the entry index)?
> 
> Best,
> S├ębastien
> 
> 
>     /** {@inheritDoc} */
>     public FieldVector<T> add(FieldVector<T> v)
>             throws DimensionMismatchException {
>         try {
>             return add((ArrayFieldVector<T>) v);
>         } catch (ClassCastException cce) {
>             checkVectorDimensions(v);
>             T[] out = buildArray(data.length);
>             for (int i = 0; i < data.length; i++) {
>                 out[i] = data[i].add(v.getEntry(i));
>                 // SHOULD I CATCH NAE HERE?

Not _catch_ NAE but _throw_ it; the line in the loop would become:

   final T entry = v.getEntry(i);
   if (entry == null) {
     throw new NullArgumentException(LocalizedFormats.INDEX, i);
   }
   out[i] = data[i].add(entry);


>             }
>             return new ArrayFieldVector<T>(field, out, false);
>         }
>     }
> 

Regards,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message