commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: [all] FindBugs' Switch statement found in class.method where default case is missing
Date Tue, 04 Sep 2012 13:01:34 GMT
Hi.

> 
> FindBugs can give warnings like:
> 
> Switch statement found in
> org.apache.commons.codec.binary.Base32.decode(byte[], int, int,
> BaseNCodec$Context) where default case is missing
> 
> In this case for [codec], it looks like the code was carefully constructed
> and that no default clause is needed.
> 
> In these cases for any component, this FindBugs issue feels like a style
> issue, is it worth changing the code to add a default clause like:
> 
>    default:
>       // ok to fall through for other values.
>       break;
> 
> Or does this feel like noise to you all?

In Math, there is this kind of code:
---CUT---
                switch (method) {
                case ILLINOIS:
                    f0 *= 0.5;
                    break;
                case PEGASUS:
                    f0 *= f1 / (f1 + fx);
                    break;
                case REGULA_FALSI:
                    // Detect early that algorithm is stuck, instead of
                    // waiting
                    // for the maximum number of iterations to be exceeded.
                    if (x == x1) {
                        throw new ConvergenceException();
                    }
                    break;
                default:
                    // Should never happen.
                    throw new MathInternalError();
                }
---CUT---


Gilles

> 
> Gary
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message