Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: local policy)
Date: Wed, 1 Aug 2012 13:00:35 -0400
Subject: My vote for release
Message-ID: <d132170f-2baa-4788-9b4b-4d215a22b4dd@sonalysts.com>
References: <19d96013-8a0a-4199-af8a-5149686213c6@sonalysts.com>
	<CAJm2B-mpbTBgkjOtTRvCx8CiWAU8a9ahc5cT2_rw0kbgm0HOiA@mail.gmail.com>
In-Reply-To: 
 <CAJm2B-mpbTBgkjOtTRvCx8CiWAU8a9ahc5cT2_rw0kbgm0HOiA@mail.gmail.com>
From: Gary Lucas <gwlucas@sonalysts.com>
To: 'Commons Developers List' <dev@commons.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"


Damjan,

I just saw that you were soliciting votes for release.   I think you've done an outstanding job and I'm all for it.   I would vote twice if I could :-)

I saw that some of the folks on the Apache page were complaining about some of the code-checking issues. I've never looked at these myself, but I suppose that many of them are not worth fixing. 

For example, somebody complained that a class shouldn't have a publically scoped array.  Let's say a programmer tried to address that.  If he writes a "get" method that is a simple pass-through returning a reference to the internal array, has he really added any security (meaning protection against accidental misuse)?  Of course not.  Suppose, instead, that he writes a method that makes a copy of the array before returning it.  Now he's improved security, but degraded the performance of the overall code... maybe seriously. And in imaging processing, performance trumps security almost every time.

Anyway, if there are specific areas in the TIFF tree or elsewhere that you would like me to review, please let me know and I'll be glad to take a look at them.

Gary


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org