Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of garydgregory@gmail.com
 designates 209.85.210.43 as permitted sender)
MIME-Version: 1.0
Date: Mon, 27 Aug 2012 09:36:07 -0400
Message-ID: 
 <CACZkXPzbDKziaT2jb=o0PfWSJy=Qr1g0F5sWQuGr9FTRBgE-iA@mail.gmail.com>
Subject: [codec] Vacuous bit mask operation on integer value in UnixCrypt
From: Gary Gregory <garydgregory@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary=e89a8fb207806d52c504c83f68cc

--e89a8fb207806d52c504c83f68cc
Content-Type: text/plain; charset=UTF-8

Hi All:

FindBugs says the following a couple of times for UnixCrypt:
"Vacuous bit mask operation on integer value (INT_VACUOUS_BIT_OPERATION)

This is an integer bit operation (and, or, or exclusive or) that doesn't do
any useful work (e.g., v & 0xffffffff)."
This makes me wonder if the whole class is correct in the first place and
if/how/why these ops got in there.

Was this translated (incorrectly) from JetSpeed's implementation? Where the
types (int vs longs?) in JetSpeed different? Where did JetSpeed get this
implementation?

Gary
-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

--e89a8fb207806d52c504c83f68cc--