Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of phil.steitz@gmail.com
 designates 209.85.160.171 as permitted sender)
Message-ID: <501F40CC.70600@gmail.com>
Date: Sun, 05 Aug 2012 20:58:04 -0700
From: Phil Steitz <phil.steitz@gmail.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:14.0) Gecko/20120713 Thunderbird/14.0
MIME-Version: 1.0
To: Commons Developers List <dev@commons.apache.org>
Subject: Re: [math]  MATH-841 gcd speed up
References: <380-2201281614413845@M2W113.mail2web.com>
In-Reply-To: <380-2201281614413845@M2W113.mail2web.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit

On 8/5/12 6:44 PM, matic@nimp.co.uk wrote:
> Hello,
>
> The gcd(int,int) method of ArithmeticUtils seems 2 times slower than the
> naive approach using modulo operator.
> Gilles tested the patch separately and found similar performance penalty.
> Please check it out: 
> https://issues.apache.org/jira/browse/MATH-841?page=com.atlassian.jira.plugi
> n.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428944#comment-1
> 3428944
>
> Anyone aware of an environment were the modulo operator is painfully slow ?
>
> Gilles pointed out that my patch don't conform to CM formating style, I
> will correct that as well as the javadoc (its mention of the binary gcd
> algorithm) if the code change is basically approved here. Please let me
> know.

It is probably worth doing some research in the archives on this
function.  I suspect there are reasons for the implementation
choices made in the current impl.  Could be bad reasons / bad impl,
but IIRC there was a fair amount of discussion on this.

Phil
>  
> Sebastien
>
> --------------------------------------------------------------------
> mail2web.com - Microsoft� Exchange solutions from a leading provider -
> http://link.mail2web.com/Business/Exchange
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org