commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject [codec] Vacuous bit mask operation on integer value in UnixCrypt
Date Mon, 27 Aug 2012 13:36:07 GMT
Hi All:

FindBugs says the following a couple of times for UnixCrypt:
"Vacuous bit mask operation on integer value (INT_VACUOUS_BIT_OPERATION)

This is an integer bit operation (and, or, or exclusive or) that doesn't do
any useful work (e.g., v & 0xffffffff)."
This makes me wonder if the whole class is correct in the first place and
if/how/why these ops got in there.

Was this translated (incorrectly) from JetSpeed's implementation? Where the
types (int vs longs?) in JetSpeed different? Where did JetSpeed get this
implementation?

Gary
-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message