commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Neidhart <thomas.neidh...@gmail.com>
Subject Re: [math] About MATH-849 and the NSWC library
Date Thu, 23 Aug 2012 22:04:46 GMT
On 08/22/2012 06:43 AM, S├ębastien Brisard wrote:
> Dear all,
> please review the code I've attached to MATH-849. The improvement in
> accuracy is great. I also implemented, besides logGamma(x), a new function
> -- namely Gamma(x).
> I would like to know if you feel the references to the NSWC library is fair.

Hi Sebastien,

I have looked briefly at the code so far, but apart from a very minor
thing (static final double HALF_LOG_2_PI is not used anymore), it looks
pretty good imho.

Great work!

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message