commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dennis Lundberg <denn...@apache.org>
Subject Re: svn commit: r1363623 - /commons/proper/logging/trunk/pom.xml
Date Tue, 07 Aug 2012 21:52:12 GMT
On 2012-07-24 23:06, sebb wrote:
> On 23 July 2012 17:20, Dennis Lundberg <dennisl@apache.org> wrote:
>> On 2012-07-20 23:26, sebb wrote:
>>> On 20 July 2012 22:02, Dennis Lundberg <dennisl@apache.org> wrote:
>>>> If this is an integration test, the proper way to exclude it is to
>>>> change its name so that it ends with "ITCase.java", see
>>>
>>> see ... what?
>>>
>>> It's not an integration test - I'm excluding WeakHashTableTestCase
>>> from the existing integration tests.
>>
>> I see, so it's the other way around.
>>
>> The integration tests should be executed by maven-failsafe-plugin, and
>> the unit tests should be executed by maven-surefire-plugin. I know that
>> commons-logging has some fairly complex integration tests. I'll try to
>> see if I can get the Maven build to follow Maven best practices.
> 
> OK, thanks.
> 
> There's and Ant build as well, which may help with deciding dependencies etc.

I got this sorted out. The Maven build now runs the same tests as the
Ant build.

To not upset the Ant build I've only made changes to pom.xml. Parts of
it kind of a hack, but I've documented it.

> 
>>> The rest of the patch just allows the IT to work.
>>>
>>>> On 2012-07-20 04:04, sebb@apache.org wrote:
>>>>> Author: sebb
>>>>> Date: Fri Jul 20 02:04:51 2012
>>>>> New Revision: 1363623
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1363623&view=rev
>>>>> Log:
>>>>> Add missing property definitions for integration tests
>>>>>
>>>>> Modified:
>>>>>     commons/proper/logging/trunk/pom.xml
>>>>>
>>>>> Modified: commons/proper/logging/trunk/pom.xml
>>>>> URL: http://svn.apache.org/viewvc/commons/proper/logging/trunk/pom.xml?rev=1363623&r1=1363622&r2=1363623&view=diff
>>>>> ==============================================================================
>>>>> --- commons/proper/logging/trunk/pom.xml (original)
>>>>> +++ commons/proper/logging/trunk/pom.xml Fri Jul 20 02:04:51 2012
>>>>> @@ -343,10 +343,16 @@ under the License.
>>>>>                <includes>
>>>>>                  <include>**/*TestCase.java</include>
>>>>>                </includes>
>>>>> +              <excludes>
>>>>> +                <exclude>**/WeakHashTableTestCase.java</exclude>
>>>>> +              </excludes>
>>>>>                <systemPropertyVariables>
>>>>>                  <!--
>>>>>                    <org.apache.commons.logging.diagnostics.dest>STDOUT</org.apache.commons.logging.diagnostics.dest>
>>>>>                  -->
>>>>> +                  <log4j12>${log4j:log4j:jar}</log4j12>
>>>>> +                  <logkit>${logkit:logkit:jar}</logkit>
>>>>> +                  <servlet-api>${javax.servlet:servlet-api:jar}</servlet-api>
>>>>>                    <commons-logging>target/${project.build.finalName}.jar</commons-logging>
>>>>>                    <commons-logging-api>target/${project.artifactId}-api-${project.version}.jar</commons-logging-api>
>>>>>                    <commons-logging-adapters>target/${project.artifactId}-adapters-${project.version}.jar</commons-logging-adapters>
>>>>> @@ -371,6 +377,19 @@ under the License.
>>>>>            <tarLongFileMode>gnu</tarLongFileMode>
>>>>>          </configuration>
>>>>>        </plugin>
>>>>> +      <!-- Define properties for referencing dependencies -->
>>>>> +      <plugin>
>>>>> +        <groupId>org.apache.maven.plugins</groupId>
>>>>> +        <artifactId>maven-dependency-plugin</artifactId>
>>>>> +        <version>2.4</version>
>>>>> +        <executions>
>>>>> +          <execution>
>>>>> +            <goals>
>>>>> +              <goal>properties</goal>
>>>>> +            </goals>
>>>>> +          </execution>
>>>>> +        </executions>
>>>>> +      </plugin>
>>>>>
>>>>>      </plugins>
>>>>>    </build>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dennis Lundberg
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>>
>> --
>> Dennis Lundberg
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


-- 
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message