commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Neidhart <thomas.neidh...@gmail.com>
Subject Re: Fwd: svn commit: r1369931 - in /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections: keyvalue/ list/
Date Mon, 06 Aug 2012 20:41:26 GMT
On 08/06/2012 10:00 PM, Jörg Schaible wrote:
> 
> =================== %< ==========================
> 
> Betreff: svn commit: r1369931 - in 
> /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections: 
> keyvalue/ list/
> Absender: tn-1oDqGaOF3Lkdnm+yROfE0A@public.gmane.org
> Datum: Mon, 06 Aug 2012 19:21:30 +0000
> Newsgruppe: gmane.comp.jakarta.commons.scm
> 
> Author: tn
> Date: Mon Aug  6 19:21:29 2012
> New Revision: 1369931
> 
> URL: http://svn.apache.org/viewvc?rev=1369931&view=rev
> Log:
> Checkstyle fixes.
> 
> [snip]
> 
> @@ -55,14 +55,18 @@ public abstract class AbstractMapEntryDe
>      }
>  
>      //-----------------------------------------------------------------------
> +    
> +    /** {@inheritDoc} */
>      public K getKey() {
>          return entry.getKey();
>      }
>  
> +    /** {@inheritDoc} */
>      public V getValue() {
>          return entry.getValue();
>      }
>  
> +    /** {@inheritDoc} */
>      public V setValue(V object) {
>          return entry.setValue(object);
>      }
> =================== %< ==========================
> 
> Geeez, what's that for an annoying change? Since Java 5 this is already the 
> default for Javadoc when overwriting/implementing methods, so adding a Javdoc 
> comment with a single @inheritDoc is completely superfluous and adds simply 
> clutter!
> 
> Can we stop Checkstyle complaining about it and revert these lines again?

If you have a better solution, I am really willing to include it.

My suggestion to go for java 6 source compatibility to be able to use
@Override tags was so far objected.

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message