commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [Math] MATH-610 (please vote)
Date Sat, 04 Aug 2012 22:01:49 GMT
On 8/4/12 11:57 AM, Gilles Sadowski wrote:
> Hi.
>
> It seems that the patch for MATH-610
>   https://issues.apache.org/jira/browse/MATH-610
> is fairly innocuous.
>
> Does anyone object to it being applied?
>
>
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
No strong objections, but I see it as needless code bloat
personally.  Also, without changing visibility (which I am -1 on)
for the inner class, I don't see an easy way to add tests for the
proposed new code.

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message