commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Hammers ...@lathspell.de>
Subject Re: [Codec] Next Commons-Codec release?
Date Mon, 27 Aug 2012 21:50:25 GMT

Am Mon, 27 Aug 2012 08:59:52 -0400
schrieb Gary Gregory <garydgregory@gmail.com>:

> On Sat, Aug 25, 2012 at 7:09 PM, Christian Hammers <ch@lathspell.de>
> wrote:
> 
> > Hello
> >
> > Am Fri, 24 Aug 2012 09:28:55 -0400
> > schrieb Gary Gregory <garydgregory@gmail.com>:
> >
> > > On Thu, Aug 23, 2012 at 4:05 PM, Thomas Neidhart
> > > <thomas.neidhart@gmail.com>wrote:
> > >
> > > > On 08/22/2012 01:23 PM, Gary Gregory wrote:
> > > >
> > > > > I did the SVN update from E and the build from a Win7 command
> > > > > line.
> > > >
> > > > Does it still not work for you?
> > >
> > >
> > > Yes, it still happens, very weird. Are you building on Win? Is
> > > this an OS-specific EOL thing? Unix vs. DOS? Arg.
> >
> > I found the cause of the "Missing a header - not enough
> > lines in file." checkstyle errors: the checkstyle.xml says:
> >
> >   <property name="headerFile" value="${checkstyle.header.file}" />
> >
> > but you define the header as property "headerFile" to the checkstyle
> > module and not as POM property. So either remove the above line
> > (untested) or apply the following patch (tested):
> >
> > Index: pom.xml
> > ===================================================================
> > --- pom.xml     (Revision 1377365)
> > +++ pom.xml     (Arbeitskopie)
> > @@ -208,6 +208,7 @@
> >      <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> >
> >  <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
> >      <commons.encoding>UTF-8</commons.encoding>
> > +
> >
> > <checkstyle.header.file>${basedir}/LICENSE-header.txt</checkstyle.header.file>
> > </properties> <build>
> >      <pluginManagement>
> > @@ -272,7 +273,6 @@
> >          <configuration>
> >            <configLocation>${basedir}/checkstyle.xml</configLocation>
> >            <enableRulesSummary>false</enableRulesSummary>
> > -          <headerFile>${basedir}/LICENSE-header.txt</headerFile>
> >          </configuration>
> >        </plugin>
> >        <plugin>
> >
> >
> Weird, the trunk code is already like that (expect the extra blank
> line).
> 
> Gary

You meant "except" instead of "expect", right? The format of the diff
is messed up, the first block does not add a blank line but the
following "<checkstyle.header.file>" line.
At least in the current trunk r1377882 the header file location is
still in the <plugins> and not in the <properties> block.

bye,

-christian-

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message