commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: [Math] MATH-610 (please vote)
Date Sat, 04 Aug 2012 23:16:07 GMT
On Sat, Aug 04, 2012 at 03:01:49PM -0700, Phil Steitz wrote:
> On 8/4/12 11:57 AM, Gilles Sadowski wrote:
> > Hi.
> >
> > It seems that the patch for MATH-610
> >   https://issues.apache.org/jira/browse/MATH-610
> > is fairly innocuous.
> >
> > Does anyone object to it being applied?
> >
> >
> > Gilles
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> No strong objections, but I see it as needless code bloat
> personally.  Also, without changing visibility (which I am -1 on)
> for the inner class, I don't see an easy way to add tests for the
> proposed new code.

Then I would rephrase:
Has anyone an objection to resolving MATH-610 as "Won't fix"?


Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message