commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject [compress] encoding parameter in ArchiveStreamFactory (was Re: svn commit: r1358626)
Date Sun, 08 Jul 2012 19:16:52 GMT
On 2012-07-08, sebb wrote:

> On 7 July 2012 20:34,  <bodewig@apache.org> wrote:
>> Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/ArchiveStreamFactory.java
>>+    private String entryEncoding = null;

> The class is currently tagged as:

> * @Immutable

> This breaks the contract.

> Can the field be made final?

If we make it a constructor arg rather than a property.

> Or turned into a parameter?

This is slightly less convenient, I'm on the fence here.  Jukka?

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message