Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3EB8A97D6 for ; Sat, 16 Jun 2012 22:05:48 +0000 (UTC) Received: (qmail 20927 invoked by uid 500); 16 Jun 2012 22:05:47 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 20807 invoked by uid 500); 16 Jun 2012 22:05:47 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 20799 invoked by uid 99); 16 Jun 2012 22:05:47 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Jun 2012 22:05:47 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates 209.85.214.171 as permitted sender) Received: from [209.85.214.171] (HELO mail-ob0-f171.google.com) (209.85.214.171) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Jun 2012 22:05:41 +0000 Received: by obbef5 with SMTP id ef5so983913obb.30 for ; Sat, 16 Jun 2012 15:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=51s8YmENHqVaLEGPwVLKGRjyMV3Ks0RU0+Ira47uSyw=; b=QHkiLC6uf/Lu4BlVRhjFS8BuT//0ocZlUXDgWIohoEMoGhkYBGsvwUAT+6P/2MH8g+ 8SNosee/F4aodKUWt2mV7cKFmkhuqul4Z0SFPJC1HhGUBN+OoMJ3uG5OYmFxZsbuF412 Otlqbe4ObV0lgWaQVypFat7YVZOlyHvBZglfVCv6zmrBB8PEknf6oUb61kO/xMEa3jvq gn4oOzYfEdhhyGG57w/ba4jexDZ0uT0oSn/zxNJt8kUKc5ngIJTDgrqA/4/ZvdbCjZkz Sku+hsKkh0EULCBi93kQ+71EcMcQVy80qqjSyd27JcA+JdVtXn6tYzM3AnjjS8WuEz96 0w1g== MIME-Version: 1.0 Received: by 10.60.8.35 with SMTP id o3mr10492791oea.45.1339884320499; Sat, 16 Jun 2012 15:05:20 -0700 (PDT) Received: by 10.182.105.70 with HTTP; Sat, 16 Jun 2012 15:05:20 -0700 (PDT) In-Reply-To: <4FDCFC09.6080708@apache.org> References: <20120616205716.CD4EA2388A33@eris.apache.org> <2272211346923711332@unknownmsgid> <4FDCFC09.6080708@apache.org> Date: Sat, 16 Jun 2012 23:05:20 +0100 Message-ID: Subject: Re: svn commit: r1351002 - /commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commons/pool/impl/GenericObjectPool.java From: sebb To: Commons Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On 16 June 2012 22:35, Mark Thomas wrote: > On 16/06/2012 22:33, sebb wrote: >> On 16 June 2012 22:23, Gary Gregory wrote: >>> Did you update the changes.xml? Did I miss that? >> >> No, I decided it was too trivial to warrant a mention. >> But feel free to update changes.xml in both versions if you disagree. > > It probably needs to be fixed in the 1.5.x branch as well. If you are referring to the code fix, that has been done - Phil already spotted that oversight. If you meant changes.xml, that's what I meant above by "... in both versions ...". > Mark > >> >>> Gary >>> >>> On Jun 16, 2012, at 16:57, "sebb@apache.org" wrote: >>> >>>> Author: sebb >>>> Date: Sat Jun 16 20:57:15 2012 >>>> New Revision: 1351002 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=3D1351002&view=3Drev >>>> Log: >>>> POOL-222 - bug in javadoc markup for GenericObjectPool#getLifo() >>>> >>>> Modified: >>>> =A0 =A0commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commo= ns/pool/impl/GenericObjectPool.java >>>> >>>> Modified: commons/proper/pool/branches/POOL_1_X/src/java/org/apache/co= mmons/pool/impl/GenericObjectPool.java >>>> URL: http://svn.apache.org/viewvc/commons/proper/pool/branches/POOL_1_= X/src/java/org/apache/commons/pool/impl/GenericObjectPool.java?rev=3D135100= 2&r1=3D1351001&r2=3D1351002&view=3Ddiff >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>>> --- commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commons/= pool/impl/GenericObjectPool.java (original) >>>> +++ commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commons/= pool/impl/GenericObjectPool.java Sat Jun 16 20:57:15 2012 >>>> @@ -991,7 +991,7 @@ public class GenericObjectPool extend >>>> =A0 =A0 =A0* the pool behaves as a FIFO queue - objects are taken from= the idle object >>>> =A0 =A0 =A0* pool in the order that they are returned to the pool. >>>> =A0 =A0 =A0* >>>> - =A0 =A0 * @return true if the pool is configured to act= as a LIFO queue >>>> + =A0 =A0 * @return true if the pool is configured to act= as a LIFO queue >>>> =A0 =A0 =A0* @since 1.4 >>>> =A0 =A0 =A0*/ >>>> =A0 =A0 =A0public synchronized boolean getLifo() { >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>> For additional commands, e-mail: dev-help@commons.apache.org >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >> For additional commands, e-mail: dev-help@commons.apache.org >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org