Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9312FC1E9 for ; Sat, 9 Jun 2012 11:05:50 +0000 (UTC) Received: (qmail 11797 invoked by uid 500); 9 Jun 2012 11:05:49 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 11464 invoked by uid 500); 9 Jun 2012 11:05:49 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 11441 invoked by uid 99); 9 Jun 2012 11:05:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jun 2012 11:05:48 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates 209.85.214.171 as permitted sender) Received: from [209.85.214.171] (HELO mail-ob0-f171.google.com) (209.85.214.171) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jun 2012 11:05:42 +0000 Received: by obfk16 with SMTP id k16so5332813obf.30 for ; Sat, 09 Jun 2012 04:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=nkRkwQS1FpqA52rEWlOjZA0KQSgPe1nOsY2hrTqmHEU=; b=hJ2wxGEUOvc9mLSL9a5J7uVcsnOzzX3B2xmfW0FKZQxrmwGsfX8Cwjj46PKBKPStLH r96+X85Q9mAZRQT2rP4u6/OzH/6z74yqgdu1/hMJuUsBjoK8FfyzmZ6CewUi8HO17PuC 1cO4rWRLLqgYNdXF811pK5mmIIKcggWGeB4HFlDXsXSNy0FGvwIs6xriI/mM91PdUXYW lEdxn2wFZKETE8oB2u9htoRnRdyEPZnVUW7NSoUb8Q5tmYzyJweqPPDgxdNZED24oF72 wIyJ+vS1HhsXjhgfaJEYFYc+LQHw8QD6dSgZehbpkYdiDUf7EOTJqJ0bGq8LN1Adejcd xX2g== MIME-Version: 1.0 Received: by 10.182.167.39 with SMTP id zl7mr10349498obb.10.1339239921689; Sat, 09 Jun 2012 04:05:21 -0700 (PDT) Received: by 10.182.105.70 with HTTP; Sat, 9 Jun 2012 04:05:21 -0700 (PDT) In-Reply-To: <20120609075402.ED634238899C@eris.apache.org> References: <20120609075402.ED634238899C@eris.apache.org> Date: Sat, 9 Jun 2012 12:05:21 +0100 Message-ID: Subject: Re: svn commit: r1348334 - in /commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/org/apache/commons/proxy2/stub: AnnotationFactory.java StubConfigurer.java From: sebb To: dev@commons.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On 9 June 2012 08:54, wrote: > Author: mbenson > Date: Sat Jun =A09 07:54:02 2012 > New Revision: 1348334 > > URL: http://svn.apache.org/viewvc?rev=3D1348334&view=3Drev > Log: > generics precision > > Modified: > =A0 =A0commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/= org/apache/commons/proxy2/stub/AnnotationFactory.java > =A0 =A0commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/= org/apache/commons/proxy2/stub/StubConfigurer.java > > Modified: commons/proper/proxy/branches/version-2.0-work/stub/src/main/ja= va/org/apache/commons/proxy2/stub/AnnotationFactory.java > URL: http://svn.apache.org/viewvc/commons/proper/proxy/branches/version-2= .0-work/stub/src/main/java/org/apache/commons/proxy2/stub/AnnotationFactory= .java?rev=3D1348334&r1=3D1348333&r2=3D1348334&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/org= /apache/commons/proxy2/stub/AnnotationFactory.java (original) > +++ commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/org= /apache/commons/proxy2/stub/AnnotationFactory.java Sat Jun =A09 07:54:02 20= 12 > @@ -214,8 +214,9 @@ public class AnnotationFactory { > =A0 =A0 =A0 =A0 =A0* {@inheritDoc} > =A0 =A0 =A0 =A0 =A0*/ > =A0 =A0 =A0 =A0 @Override > - =A0 =A0 =A0 =A0public Class getStubType() { > - =A0 =A0 =A0 =A0 =A0 =A0return AnnotationFactory.getStubType(); > + =A0 =A0 =A0 =A0@SuppressWarnings("unchecked") Why is it safe to ignore the warning? This should be documented in a comment please. > + =A0 =A0 =A0 =A0public Class getStubType() { > + =A0 =A0 =A0 =A0 =A0 =A0return (Class) AnnotationFactory.get= StubType(); > =A0 =A0 =A0 =A0 } > > =A0 =A0 =A0 =A0 /** > > Modified: commons/proper/proxy/branches/version-2.0-work/stub/src/main/ja= va/org/apache/commons/proxy2/stub/StubConfigurer.java > URL: http://svn.apache.org/viewvc/commons/proper/proxy/branches/version-2= .0-work/stub/src/main/java/org/apache/commons/proxy2/stub/StubConfigurer.ja= va?rev=3D1348334&r1=3D1348333&r2=3D1348334&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/org= /apache/commons/proxy2/stub/StubConfigurer.java (original) > +++ commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/org= /apache/commons/proxy2/stub/StubConfigurer.java Sat Jun =A09 07:54:02 2012 > @@ -79,7 +79,7 @@ public abstract class StubConfigurer > =A0 =A0 =A0* Get the stubType. > =A0 =A0 =A0* @return Class > =A0 =A0 =A0*/ > - =A0 =A0public Class getStubType() { > + =A0 =A0public Class getStubType() { > =A0 =A0 =A0 =A0 return stubType; > =A0 =A0 } > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org