Return-Path: 
 <dev-return-136145-apmail-commons-dev-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-dev-archive@www.apache.org
Delivered-To: apmail-commons-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 0B13990B5
	for <apmail-commons-dev-archive@www.apache.org>;
 Sat,  9 Jun 2012 13:23:01 +0000 (UTC)
Received: (qmail 92927 invoked by uid 500); 9 Jun 2012 13:23:00 -0000
Delivered-To: apmail-commons-dev-archive@commons.apache.org
Received: (qmail 92840 invoked by uid 500); 9 Jun 2012 13:23:00 -0000
Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@commons.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@commons.apache.org>
List-Post: <mailto:dev@commons.apache.org>
List-Id: <dev.commons.apache.org>
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Delivered-To: mailing list dev@commons.apache.org
Received: (qmail 92826 invoked by uid 99); 9 Jun 2012 13:23:00 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jun 2012 13:23:00 +0000
X-ASF-Spam-Status: No, hits=-0.7 required=5.0
	tests=RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of gudnabrsam@gmail.com
 designates 209.85.210.43 as permitted sender)
Received: from [209.85.210.43] (HELO mail-pz0-f43.google.com) (209.85.210.43)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jun 2012 13:22:55 +0000
Received: by dajz8 with SMTP id z8so3997801daj.30
        for <dev@commons.apache.org>; Sat, 09 Jun 2012 06:22:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:reply-to:in-reply-to:references:date:message-id
         :subject:from:to:content-type:content-transfer-encoding;
        bh=BLmv4sNKY9FKMvpWyPnXgV9+zU/yCaUndz3xvGCjvcM=;
        b=VNvHX+6e61XXvjK4ycp/HHZ7eh5xVUCpwDxQU93DpoGQ7O3khjL0A9HQJWiqkOcfAl
         WtyYKd5mOliXY/uemnjeeAGA2vI8E/fu0KO8kvxP1rOrbAWEGuqSuigRcpC79wSABAGy
         uX6q65zSP+pbUJAmV0GqPVIwOSZjpxAJ2w7yOMi5TcG0fE0BW7mRuYlOkdo9Q6SwPlaw
         MK1pen8KOHiBGfMSdG0kBB4gu4Rnlmuy24FlECjEcXrYzPwIAal53EvQcYLXnTQOr5CJ
         4MGriLpXtDk5adcnQNAioWz+KoSsL6zjdaJesFeWRrWESLrn/CJfSPbQFon92PTJWaz8
         MReA==
MIME-Version: 1.0
Received: by 10.68.240.99 with SMTP id vz3mr8466660pbc.60.1339248154718; Sat,
 09 Jun 2012 06:22:34 -0700 (PDT)
Received: by 10.68.58.2 with HTTP; Sat, 9 Jun 2012 06:22:34 -0700 (PDT)
Reply-To: gudnabrsam@gmail.com
In-Reply-To: <4FD336A8.1010902@sandglass-software.com>
References: <20120609075402.ED634238899C@eris.apache.org>
	<CAOGo0VYBJCSdaMZKXaowCoEwvr=naJnGs0J5CcZAbtisJhL7ag@mail.gmail.com>
	<4FD336A8.1010902@sandglass-software.com>
Date: Sat, 9 Jun 2012 08:22:34 -0500
Message-ID: 
 <CAE9L6G3LXTPXg2SsCqUbiBTOGX=nY+p__BXmnL6bz-3gD=_Niw@mail.gmail.com>
Subject: Re: svn commit: r1348334 - in
 /commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/org/apache/commons/proxy2/stub:
 AnnotationFactory.java StubConfigurer.java
From: Matt Benson <gudnabrsam@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Virus-Checked: Checked by ClamAV on apache.org

On Sat, Jun 9, 2012 at 6:42 AM, Adrian Crum
<adrian.crum@sandglass-software.com> wrote:
> Actually, that cast should not be necessary. Try
>
> return AnnotationFactory.<Annotation>getStubType();

Seems reasonable, Adrian, but still poppped a compile error.  Thanks anyway=
!  ;)

Matt

>
> -Adrian
>
>
> On 6/9/2012 12:05 PM, sebb wrote:
>>
>> On 9 June 2012 08:54,<mbenson@apache.org> =A0wrote:
>>>
>>> Author: mbenson
>>> Date: Sat Jun =A09 07:54:02 2012
>>> New Revision: 1348334
>>>
>>> URL: http://svn.apache.org/viewvc?rev=3D1348334&view=3Drev
>>> Log:
>>> generics precision
>>>
>>> Modified:
>>>
>>> =A0commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/or=
g/apache/commons/proxy2/stub/AnnotationFactory.java
>>>
>>> =A0commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/or=
g/apache/commons/proxy2/stub/StubConfigurer.java
>>>
>>> Modified:
>>> commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/org/a=
pache/commons/proxy2/stub/AnnotationFactory.java
>>> URL:
>>> http://svn.apache.org/viewvc/commons/proper/proxy/branches/version-2.0-=
work/stub/src/main/java/org/apache/commons/proxy2/stub/AnnotationFactory.ja=
va?rev=3D1348334&r1=3D1348333&r2=3D1348334&view=3Ddiff
>>>
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>>> ---
>>> commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/org/a=
pache/commons/proxy2/stub/AnnotationFactory.java
>>> (original)
>>> +++
>>> commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/org/a=
pache/commons/proxy2/stub/AnnotationFactory.java
>>> Sat Jun =A09 07:54:02 2012
>>> @@ -214,8 +214,9 @@ public class AnnotationFactory {
>>> =A0 =A0 =A0 =A0 =A0* {@inheritDoc}
>>> =A0 =A0 =A0 =A0 =A0*/
>>> =A0 =A0 =A0 =A0 @Override
>>> - =A0 =A0 =A0 =A0public Class<? extends Annotation> =A0getStubType() {
>>> - =A0 =A0 =A0 =A0 =A0 =A0return AnnotationFactory.getStubType();
>>> + =A0 =A0 =A0 =A0@SuppressWarnings("unchecked")
>>
>> Why is it safe to ignore the warning?
>> This should be documented in a comment please.
>>
>>> + =A0 =A0 =A0 =A0public Class<Annotation> =A0getStubType() {
>>> + =A0 =A0 =A0 =A0 =A0 =A0return (Class<Annotation>) AnnotationFactory.g=
etStubType();
>>> =A0 =A0 =A0 =A0 }
>>>
>>> =A0 =A0 =A0 =A0 /**
>>>
>>> Modified:
>>> commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/org/a=
pache/commons/proxy2/stub/StubConfigurer.java
>>> URL:
>>> http://svn.apache.org/viewvc/commons/proper/proxy/branches/version-2.0-=
work/stub/src/main/java/org/apache/commons/proxy2/stub/StubConfigurer.java?=
rev=3D1348334&r1=3D1348333&r2=3D1348334&view=3Ddiff
>>>
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>>> ---
>>> commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/org/a=
pache/commons/proxy2/stub/StubConfigurer.java
>>> (original)
>>> +++
>>> commons/proper/proxy/branches/version-2.0-work/stub/src/main/java/org/a=
pache/commons/proxy2/stub/StubConfigurer.java
>>> Sat Jun =A09 07:54:02 2012
>>> @@ -79,7 +79,7 @@ public abstract class StubConfigurer<T>
>>> =A0 =A0 =A0* Get the stubType.
>>> =A0 =A0 =A0* @return Class<T>
>>> =A0 =A0 =A0*/
>>> - =A0 =A0public Class<? extends T> =A0getStubType() {
>>> + =A0 =A0public Class<T> =A0getStubType() {
>>> =A0 =A0 =A0 =A0 return stubType;
>>> =A0 =A0 }
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org