Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of thomas.neidhart@gmail.com
 designates 74.125.82.171 as permitted sender)
Message-ID: <4FD67E74.4010308@gmail.com>
Date: Tue, 12 Jun 2012 01:25:40 +0200
From: Thomas Neidhart <thomas.neidhart@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux i686;
 rv:12.0) Gecko/20120430 Thunderbird/12.0.1
MIME-Version: 1.0
To: Commons Developers List <dev@commons.apache.org>
Subject: Re: svn commit: r1348024 - in /commons/proper/math/trunk/src:
 main/java/org/apache/commons/math3/stat/inference/MannWhitneyUTest.java
 test/java/org/apache/commons/math3/stat/inference/MannWhitneyUTestTest.java
References: <20120608110411.E492D238899C@eris.apache.org>
In-Reply-To: <20120608110411.E492D238899C@eris.apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 06/08/2012 01:04 PM, mikl@apache.org wrote:
> Author: mikl
> Date: Fri Jun  8 11:04:11 2012
> New Revision: 1348024
> 
> URL: http://svn.apache.org/viewvc?rev=1348024&view=rev
> Log:
> MATH-790: Patch applied to fix the overflow issue.
> 
> Modified:
>     commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/inference/MannWhitneyUTest.java
>     commons/proper/math/trunk/src/test/java/org/apache/commons/math3/stat/inference/MannWhitneyUTestTest.java
> 
> Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/inference/MannWhitneyUTest.java
> URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/inference/MannWhitneyUTest.java?rev=1348024&r1=1348023&r2=1348024&view=diff
> ==============================================================================
> --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/inference/MannWhitneyUTest.java (original)
> +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/stat/inference/MannWhitneyUTest.java Fri Jun  8 11:04:11 2012
> @@ -170,11 +170,11 @@ public class MannWhitneyUTest {
>                                               final int n2)
>          throws ConvergenceException, MaxCountExceededException {
>  
> -        final int n1n2prod = n1 * n2;
> +        final double n1n2prod = n1 * n2;
>  
>          // http://en.wikipedia.org/wiki/Mann%E2%80%93Whitney_U#Normal_approximation
> -        final double EU = (double) n1n2prod / 2.0;
> -        final double VarU = (double) (n1n2prod * (n1 + n2 + 1)) / 12.0;
> +        final double EU = n1n2prod / 2.0;
> +        final double VarU = n1n2prod * (n1 + n2 + 1) / 12.0;
>  
>          final double z = (Umin - EU) / FastMath.sqrt(VarU);

just a small thing, but wouldn't it be better to do a long
multiplication and convert the result to double?

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org