Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of beneritter@googlemail.com
 designates 209.85.214.43 as permitted sender)
References: <4FE6DDBA.4000803@gmail.com> <3140324993976957346@unknownmsgid>
In-Reply-To: <3140324993976957346@unknownmsgid>
Mime-Version: 1.0 (1.0)
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii
Message-Id: <35B5CA8A-4784-4C5E-B3D9-C701BD12B4F3@googlemail.com>
Cc: Commons Developers List <dev@commons.apache.org>
From: Benedikt Ritter <beneritter@googlemail.com>
Subject: Re: [collections] Cleanup of trunk
Date: Sun, 24 Jun 2012 14:35:04 +0200
To: Commons Developers List <dev@commons.apache.org>

Are we going through that Java 5 vs Java 6 discussion again? ;)

Thomas: I always wanted to work on collections but there hasn't been much ac=
tivity since I joined the ML. I'd be happy to contribute some patches.

Benedikt

Von meinem iPhone gesendet

Am 24.06.2012 um 14:10 schrieb Gary Gregory <garydgregory@gmail.com>:

> I am +1 to all your proposed changes.
>=20
> Gary
>=20
> On Jun 24, 2012, at 5:29, Thomas Neidhart <thomas.neidhart@gmail.com> wrot=
e:
>=20
>> Hi,
>>=20
>> I recently started to work more on collections and cleaning up the trunk
>> to make it a candidate for a release and would like to ask a few question=
s:
>>=20
>> - there is still lots of javadoc missing, moving the source code level
>>  to Java 1.6 would allow the use of @Override in more places (instead
>>  of putting a /** {inheritDoc} */ everywhere)
>>=20
>>  this has been discussed for vfs a few weeks ago, and my
>>  understanding was that this proposal was well received, so what do
>>  you think about doing the same for collections?
>>=20
>> - unit tests: there are currently two unit tests for certain classes
>>  that are almost similar, e.g. TestListOrderedMap and
>>  TestListOrderedMap2. Does anybody know why this exists?
>>=20
>>  also I would like to go to annotation based unit tests like in the
>>  other components and rename the tests to the common style:
>>  ClassNameTest.
>>=20
>> - consistency with commons rules. There are several things that are
>>  different to other components atm:
>>=20
>>  o authors contained in source files
>>  o no changes.xml to track changes
>>  o since and version tags are a bit different
>>  o package.html should be package-info.java
>>=20
>>  and I guess other things too that I have not spotted yet.
>>=20
>>=20
>> Are there any objections / suggestions to continue with the cleanup?
>>=20
>> Thomas
>>=20
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>=20

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org