Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 40DE9C0E2 for ; Wed, 13 Jun 2012 15:39:32 +0000 (UTC) Received: (qmail 52269 invoked by uid 500); 13 Jun 2012 15:39:31 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 52129 invoked by uid 500); 13 Jun 2012 15:39:31 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 52120 invoked by uid 99); 13 Jun 2012 15:39:31 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jun 2012 15:39:31 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.131] (HELO eos.apache.org) (140.211.11.131) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jun 2012 15:39:30 +0000 Received: from eos.apache.org (localhost [127.0.0.1]) by eos.apache.org (Postfix) with ESMTP id ABFC55F8 for ; Wed, 13 Jun 2012 15:39:10 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Apache Wiki To: Apache Wiki Date: Wed, 13 Jun 2012 15:39:10 -0000 Message-ID: <20120613153910.16734.61965@eos.apache.org> Subject: =?utf-8?q?=5BCommons_Wiki=5D_Update_of_=22Sanity_Check_of_APIs=2C_etc=2E?= =?utf-8?q?=22_by_MattBenson?= Auto-Submitted: auto-generated X-Virus-Checked: Checked by ClamAV on apache.org Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for c= hange notification. The "Sanity Check of APIs, etc." page has been changed by MattBenson: http://wiki.apache.org/commons/Sanity%20Check%20of%20APIs%2C%20etc.?action= =3Ddiff&rev1=3D7&rev2=3D8 (Same question would apply to -Predicate and -Procedure in addition to= -Function) Using a vararg parameter would preclude the binary (and hypothe= tical ternary, etc.) functors from supporting different strongly typed argu= ments. I think it would be a step backward. MJB = * '''''EachElement should be able to work on any Iterable. Also I'm not = sure to understand why its constructor is public.''''' - Agreed about the first point; added https://issues.apache.org/jira/bro= wse/FUNCTOR-13 . As to why the ctor is public, the javadoc says "This cons= tructor is public to permit tools that require a JavaBean instance to opera= te." Not sure how many tools actually still need this. Velocity was the p= rimary suspect for ages; does anyone know if it still needs a bean instance= ? '''UPDATE''' it was quick work to google that Velocity does now support c= alling static methods, so we can IMO end this practice for current and futu= re development throughout Commons. + Agreed about the first point; added https://issues.apache.org/jira/bro= wse/FUNCTOR-13 . As to why the ctor is public, the javadoc says "This cons= tructor is public to permit tools that require a JavaBean instance to opera= te." Not sure how many tools actually still need this. Velocity was the p= rimary suspect for ages; does anyone know if it still needs a bean instance= ? '''UPDATE''' it was quick work to google that Velocity does now support c= alling static methods with no object instance, so we can IMO end this pract= ice for current and future development throughout Commons. = * '''''Shouldn't Generator implement Iterable?''''' It doesn't seem so to me. It's possible some more expository name cou= ld be found for Generator. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org