Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: local policy)
Date: Sat, 9 Jun 2012 02:48:45 +0200
From: Gilles Sadowski <gilles@harfang.homelinux.org>
To: dev@commons.apache.org
Subject: Re: [Math] HarmonicFitter and GaussianFitter
Message-ID: <20120609004845.GI10938@dusk.harfang.homelinux.org>
Mail-Followup-To: dev@commons.apache.org
References: <20120609000042.GG10938@dusk.harfang.homelinux.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120609000042.GG10938@dusk.harfang.homelinux.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-DCC-scarlet.be-Metrics: hel 20002; Body=1 Fuz1=1 Fuz2=1
X-Virus-Scanned: clamav-milter 0.97.1-exp at hel
X-Virus-Status: Clean
X-Virus-Checked: Checked by ClamAV on apache.org

On Sat, Jun 09, 2012 at 02:00:42AM +0200, Gilles Sadowski wrote:
> Hi.
> 
> I'm a bit annoyed that "HarmonicFitter" and "GaussianFitter" suffer from the
> same design flaw as "PolynomialFitter", namely that it is possible to call
> the non-overridden "fit" with an argument that is not of the right type
> (i.e. "HarmonicOscillator.Parametric" and "Gaussian.Parametric",
> respectively).
> However we cannot simply remove them as in MATH-800, since those classes
> perform non-trivial computations.
> One possibility is to override the "fit" methods that should not be used,
> and have them throw an exception.
> 
> What do you think?
> Which exception would be most appropriate?

This doesn't work (I should have tested it before sending the message...).

However, I think that using generics might solve the problem:
---
public class CurveFitter<T extends ParametricUnivariateFunction>
---

And thus
---
public class GaussianFitter extends CurveFitter<Gaussian.Parametric>
---

Then, we could keep "PolynomialFitter".


OK for this change?


Regards,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org