commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1351002 - /commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
Date Sun, 17 Jun 2012 11:08:26 GMT
On 17 June 2012 08:51,  <markt@apache.org> wrote:
> sebb <sebbaz@gmail.com> wrote:
>
>>On 16 June 2012 23:09, Mark Thomas <markt@apache.org> wrote:
>>> On 16/06/2012 23:05, sebb wrote:
>>>> On 16 June 2012 22:35, Mark Thomas <markt@apache.org> wrote:
>>>>> On 16/06/2012 22:33, sebb wrote:
>>>>>> On 16 June 2012 22:23, Gary Gregory <garydgregory@gmail.com>
>>wrote:
>>>>>>> Did you update the changes.xml? Did I miss that?
>>>>>>
>>>>>> No, I decided it was too trivial to warrant a mention.
>>>>>> But feel free to update changes.xml in both versions if you
>>disagree.
>>>>>
>>>>> It probably needs to be fixed in the 1.5.x branch as well.
>>>>
>>>> If you are referring to the code fix,
>>>
>>> I am.
>>>
>>>> that has been done
>>>
>>> It hasn't.
>>>
>>>> - Phil already spotted that oversight.
>>>
>>> I know.
>>>
>>>> If you meant changes.xml,
>>>
>>> I didn't.
>>>
>>>> that's what I meant above by "... in both versions ...".
>>>
>>> There are three versions of POOL currently under development, not 2.
>>
>>That's handy.
>>
>>What's the branch for the 3rd one?
>
> 1_5_RELEASE

OK, done.

> Mark
>
>
>>
>>I've updated trunk and POOL_1_X but I've no idea what the 3rd is.
>>
>>Perhaps there should be a readme file at the same level as branches and
>>trunk.
>>
>>> Mark
>>>
>>>>
>>>>> Mark
>>>>>
>>>>>>
>>>>>>> Gary
>>>>>>>
>>>>>>> On Jun 16, 2012, at 16:57, "sebb@apache.org" <sebb@apache.org>
>>wrote:
>>>>>>>
>>>>>>>> Author: sebb
>>>>>>>> Date: Sat Jun 16 20:57:15 2012
>>>>>>>> New Revision: 1351002
>>>>>>>>
>>>>>>>> URL: http://svn.apache.org/viewvc?rev=1351002&view=rev
>>>>>>>> Log:
>>>>>>>> POOL-222 - bug in javadoc markup for GenericObjectPool#getLifo()
>>>>>>>>
>>>>>>>> Modified:
>>>>>>>>
>> commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
>>>>>>>>
>>>>>>>> Modified:
>>commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
>>>>>>>> URL:
>>http://svn.apache.org/viewvc/commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commons/pool/impl/GenericObjectPool.java?rev=1351002&r1=1351001&r2=1351002&view=diff
>>>>>>>>
>>==============================================================================
>>>>>>>> ---
>>commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
>>(original)
>>>>>>>> +++
>>commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
>>Sat Jun 16 20:57:15 2012
>>>>>>>> @@ -991,7 +991,7 @@ public class GenericObjectPool<T>
extend
>>>>>>>>      * the pool behaves as a FIFO queue - objects are
taken from
>>the idle object
>>>>>>>>      * pool in the order that they are returned to the
pool.
>>>>>>>>      *
>>>>>>>> -     * @return <code>true</true> if the pool
is configured to
>>act as a LIFO queue
>>>>>>>> +     * @return <code>true</code> if the pool
is configured to
>>act as a LIFO queue
>>>>>>>>      * @since 1.4
>>>>>>>>      */
>>>>>>>>      public synchronized boolean getLifo() {
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>>
>>>>>>
>>>>>>
>>---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>
>>>>
>>---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message