commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: svn commit: r1354966 - in /commons/proper/vfs/trunk: core/pom.xml core/src/test/java/org/apache/commons/vfs2/provider/local/test/PermissionsTests.java pom.xml
Date Thu, 28 Jun 2012 12:52:52 GMT
On Thu, Jun 28, 2012 at 8:23 AM, sebb <sebbaz@gmail.com> wrote:

> On 28 June 2012 13:10,  <ggregory@apache.org> wrote:
> > Author: ggregory
> > Date: Thu Jun 28 12:10:27 2012
> > New Revision: 1354966
> >
> > URL: http://svn.apache.org/viewvc?rev=1354966&view=rev
> > Log:
> > Fix file permission test when not on Windows.
> >
> > Modified:
> >    commons/proper/vfs/trunk/core/pom.xml
> >
>  commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/local/test/PermissionsTests.java
> >    commons/proper/vfs/trunk/pom.xml
> >
> > Modified: commons/proper/vfs/trunk/core/pom.xml
> > URL:
> http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/pom.xml?rev=1354966&r1=1354965&r2=1354966&view=diff
> >
> ==============================================================================
> > --- commons/proper/vfs/trunk/core/pom.xml (original)
> > +++ commons/proper/vfs/trunk/core/pom.xml Thu Jun 28 12:10:27 2012
> > @@ -81,6 +81,11 @@
> >       <artifactId>junit</artifactId>
> >       <scope>test</scope>
> >     </dependency>
> > +    <dependency>
> > +      <groupId>org.apache.commons</groupId>
> > +      <artifactId>commons-lang3</artifactId>
> > +      <scope>test</scope>
> > +    </dependency>
> >     <!-- Test FTP with Apache FTP Server (MINA) -->
> >     <dependency>
> >       <groupId>org.apache.ftpserver</groupId>
> >
> > Modified:
> commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/local/test/PermissionsTests.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/local/test/PermissionsTests.java?rev=1354966&r1=1354965&r2=1354966&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/local/test/PermissionsTests.java
> (original)
> > +++
> commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/local/test/PermissionsTests.java
> Thu Jun 28 12:10:27 2012
> > @@ -18,6 +18,8 @@ package org.apache.commons.vfs2.provider
> >
> >  import junit.framework.Assert;
> >
> > +import org.apache.commons.lang3.SystemUtils;
> > +
> >  import org.apache.commons.vfs2.FileObject;
> >  import org.apache.commons.vfs2.test.AbstractProviderTestCase;
> >
> > @@ -32,7 +34,7 @@ public class PermissionsTests extends Ab
> >     public void testFolderIsExecutable() throws Exception
> >     {
> >         final FileObject folder =
> this.getReadFolder().resolveFile("file1.txt");
> > -        Assert.assertTrue(folder.isExecutable());
> > +        Assert.assertEquals(SystemUtils.IS_OS_WINDOWS,
> folder.isExecutable());
>
> Seems like overkill to use Commons Lang just for this one line.
>
> Yes, it's only a test dependency, but still.
>

Indeed, this is for testing only ATM. I'm sure it's not the only API we'll
end up using. I'd rather eat our own dog food than spending time extracting
the code and duplicating it.

Gary



> >     }
> >
> >  }
> >
> > Modified: commons/proper/vfs/trunk/pom.xml
> > URL:
> http://svn.apache.org/viewvc/commons/proper/vfs/trunk/pom.xml?rev=1354966&r1=1354965&r2=1354966&view=diff
> >
> ==============================================================================
> > --- commons/proper/vfs/trunk/pom.xml (original)
> > +++ commons/proper/vfs/trunk/pom.xml Thu Jun 28 12:10:27 2012
> > @@ -370,6 +370,12 @@
> >         <version>4.10</version>
> >         <scope>test</scope>
> >       </dependency>
> > +      <dependency>
> > +        <groupId>org.apache.commons</groupId>
> > +        <artifactId>commons-lang3</artifactId>
> > +        <version>3.1</version>
> > +        <scope>test</scope>
> > +      </dependency>
> >       <!-- Test FTP with Apache FTP Server (MINA) -->
> >       <dependency>
> >         <groupId>org.apache.ftpserver</groupId>
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message