Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates
 209.85.214.171 as permitted sender)
MIME-Version: 1.0
Sender: sebbaz@gmail.com
In-Reply-To: 
 <CAOGo0VZCR+aRG7tPk7b5vqWZx9CK36NFUN-8U1UxQN7iQk-UJA@mail.gmail.com>
References: <20120504180227.E9E10238896F@eris.apache.org>
	<CAOGo0VZCR+aRG7tPk7b5vqWZx9CK36NFUN-8U1UxQN7iQk-UJA@mail.gmail.com>
Date: Sat, 5 May 2012 11:22:10 +0100
Message-ID: 
 <CAOGo0Vbr2DfwT_zp3dgohzTYzuMM3gT85RSQX0nE_pHxx1BgBQ@mail.gmail.com>
Subject: Re: svn commit: r1334103 -
 /commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
From: sebb AT ASF <sebb@apache.org>
To: dev@commons.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 4 May 2012 19:05, sebb AT ASF <sebb@apache.org> wrote:
> The following change to the GKOP ctor seems to fix the problem:
>
>
> =A0 =A0 =A0 =A0if (factory =3D=3D null) {
> =A0 =A0 =A0 =A0 =A0 =A0this.close(); // <=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D close the parent
> =A0 =A0 =A0 =A0 =A0 =A0throw new IllegalArgumentException("factory may no=
t be null");
> =A0 =A0 =A0 =A0}
>
> Not 100% sure if that is the correct fix - perhaps tearDown() needs to
> be adjusted?

I've fixed GOP and GKOP to call jmxUnregister() instead.
Hope that's OK; it fixes the remaining test errors.

> On 4 May 2012 19:02, =A0<sebb@apache.org> wrote:
>> Author: sebb
>> Date: Fri May =A04 18:02:27 2012
>> New Revision: 1334103
>>
>> URL: http://svn.apache.org/viewvc?rev=3D1334103&view=3Drev
>> Log:
>> Add specific test for null factory
>> TODO causes tearDown error
>>
>> Modified:
>> =A0 =A0commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/=
impl/TestGenericKeyedObjectPool.java
>>
>> Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/poo=
l2/impl/TestGenericKeyedObjectPool.java
>> URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/jav=
a/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java?rev=3D13341=
03&r1=3D1334102&r2=3D1334103&view=3Ddiff
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/imp=
l/TestGenericKeyedObjectPool.java (original)
>> +++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/imp=
l/TestGenericKeyedObjectPool.java Fri May =A04 18:02:27 2012
>> @@ -1111,6 +1111,14 @@ public class TestGenericKeyedObjectPool
>> =A0 =A0 =A0 =A0 pool.close();
>> =A0 =A0 }
>>
>> + =A0 =A0@Test(expected=3DIllegalArgumentException.class)
>> + =A0 =A0public void testConstructorNullFactory() {
>> + =A0 =A0 =A0 =A0// add dummy assert (won't be invoked because of IAE) t=
o avoid "unused" warning
>> + =A0 =A0 =A0 =A0assertNotNull(new GenericKeyedObjectPool<String,String>=
(null));
>> + =A0 =A0 =A0 =A0// TODO this currently causes tearDown to report an err=
or
>> + =A0 =A0 =A0 =A0// Looks like GKOP needs to call close() on its parent =
before throwing IAE
>> + =A0 =A0}
>> +
>> =A0 =A0 @Test(timeout=3D60000)
>> =A0 =A0 public void testExceptionOnPassivateDuringReturn() throws Except=
ion {
>> =A0 =A0 =A0 =A0 SimpleFactory<String> factory =3D new SimpleFactory<Stri=
ng>();
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org